Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ntp: add patch to support for libressl
Date: Thu, 23 Nov 2017 23:29:52 +0100	[thread overview]
Message-ID: <20171123232952.3defa400@windsurf.lan> (raw)
In-Reply-To: <9d7c2e3e-7bad-128b-a915-d0f73f3c126c@mind.be>

Hello,

On Thu, 23 Nov 2017 23:27:18 +0100, Arnout Vandecappelle wrote:

> > Arnout, Peter, Yann, I think we discussed this topic during the
> > Buildroot meeting, and concluded we didn't want patches in Buildroot to
> > enable LibreSSL compatibility with a package. Do we stand on this
> > position, and reject Adam's contribution on ntp?  
> 
>  I don't think the conclusion was that we would reject patches to enable
> LibreSSL compatibility outright, only:
> 
> >   
> >> + #ifndef OPENSSL_VERSION_NUMBER
> >> ++#ifndef LIBRESSL_VERSION_NUMBER  
> > 
> > In addition, this continue to use the LIBRESSL_VERSION_NUMBER approach,
> > which will fail when libressl gains support for new APIs.  
> 
>  we would reject this approach because I believe it is not upstreamable.
> 
>  I think upstreamable patches are acceptable. And maybe even the
> LIBRESSL_VERSION_NUMBER approach is OK - but then I first want to see a reliable
> upstream accept it.

The issue here is that Adam has submitted the patch upstream a while
ago (see bugs.ntp.org/show_bug.cgi?id=3401#c3), and upstream has
reacted.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-11-23 22:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08 12:11 [Buildroot] [PATCH 1/1] ntp: add patch to support for libressl Adam Duskett
2017-11-23 21:51 ` Thomas Petazzoni
2017-11-23 22:27   ` Arnout Vandecappelle
2017-11-23 22:29     ` Thomas Petazzoni [this message]
2017-11-23 22:39       ` Arnout Vandecappelle
2017-11-24  7:50         ` Thomas Petazzoni
2017-11-25 12:43   ` Yann E. MORIN
2017-11-25 16:47     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171123232952.3defa400@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox