Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] hostapd: add support for Realtek driver
Date: Sat, 25 Nov 2017 11:46:43 +0100	[thread overview]
Message-ID: <20171125114643.5b290738@windsurf.lan> (raw)
In-Reply-To: <20171125103252.GA1248@hpx>

Hello,

On Sat, 25 Nov 2017 13:32:52 +0300, Alexander Mukhin wrote:

> > So, I've applied to next. We'll see how often it breaks hostapd (or
> > not).  
> 
> My patch as it was submitted two months ago will not apply to the
> current buildroot tree because of the other patches applied to hostapd
> since then. I'll send the updated version.

I have already applied your patch. So if any fix is needed, please base
your new patch on top of the "next" branch.

But I did test the build of hostapd with the realtek driver support
applied, and it built fine for me. So I'm not sure why you say it
doesn't apply.

> There's no problem in rejecting the patch. One can easily get by without
> it by adding local changes to external.mk:
> 
> HOSTAPD_PATCH += https://github.com/pritambaral/hostapd-rtl871xdrv/raw/master/rtlxdrv.patch
> BR_NO_CHECK_HASH_FOR += rtlxdrv.patch
> HOSTAPD_CONFIG_SET += CONFIG_DRIVER_RTW

If things turn out to be too annoying because it breaks too often, we
might end up doing that. But it's obviously nicer for users if the
feature is integrated in Buildroot itself.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-11-25 10:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-04 17:11 [Buildroot] Realtek-patched hostapd Alexander Mukhin
2017-09-07 19:54 ` Peter Korsgaard
2017-09-08 11:19   ` Alexander Mukhin
2017-09-11 23:14     ` Arnout Vandecappelle
2017-09-14  8:57       ` Alexander Mukhin
2017-09-14  9:00     ` [Buildroot] [PATCH] hostapd: add support for Realtek driver Alexander Mukhin
2017-09-14  9:32       ` Baruch Siach
2017-09-14 10:19         ` Alexander Mukhin
2017-09-14 10:24           ` Baruch Siach
2017-09-14 10:39             ` Alexander Mukhin
2017-09-14 11:08     ` Alexander Mukhin
2017-11-03 16:17       ` Angelo Compagnucci
2017-11-24 20:58       ` Thomas Petazzoni
2017-11-25 10:32         ` Alexander Mukhin
2017-11-25 10:46           ` Thomas Petazzoni [this message]
2017-11-25 11:08             ` [Buildroot] [PATCH] hostapd: keep previous patches when DRIVER_RTW set Alexander Mukhin
2017-11-25 11:18             ` [Buildroot] [PATCH] hostapd: add support for Realtek driver Alexander Mukhin
2017-11-25 10:50         ` Alexander Mukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171125114643.5b290738@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox