From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] axel: bump to version 2.16
Date: Sat, 25 Nov 2017 13:23:57 +0100 [thread overview]
Message-ID: <20171125132357.7431e5c1@windsurf.lan> (raw)
In-Reply-To: <20171125044447.7188-1-ismael@iodev.co.uk>
Hello,
On Sat, 25 Nov 2017 01:44:47 -0300, Ismael Luceno wrote:
> - Change upstream URL.
> - Add optional dependency on libressl/openssl.
> - Switch to autotools-package.
>
> Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
I've applied to next, but now that I review the patch again, I see a
problem, see below.
> +ifeq ($(BR2_PACKAGE_LIBRESSL),y)
> +AXEL_CONF_OPTS += --with-ssl
> +AXEL_DEPENDENCIES += libressl
This is not needed, because the below case with BR2_PACKAGE_OPENSSL is
sufficient. Indeed openssl is not a virtual package, that depends
either on libopenssl or libressl depending on which implementation is
selected.
> +else ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +AXEL_CONF_OPTS += --with-ssl
> +AXEL_DEPENDENCIES += openssl
Could you send a follow-up patch (based on the next branch) that fixes
this?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-11-25 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-25 4:44 [Buildroot] [PATCH] axel: bump to version 2.16 Ismael Luceno
2017-11-25 12:23 ` Thomas Petazzoni [this message]
2017-12-04 8:14 ` Thomas Petazzoni
2017-12-04 19:04 ` Ismael Luceno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171125132357.7431e5c1@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox