From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] board/qemu/x86*: use quotes around -append Qemu option value
Date: Mon, 27 Nov 2017 21:56:37 +0100 [thread overview]
Message-ID: <20171127205637.GJ2950@scaer> (raw)
In-Reply-To: <20171121080815.31347-2-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2017-11-21 09:08 +0100, Thomas Petazzoni spake thusly:
> This helps the toolchains.free-electrons.com build logic re-use
> directly the Qemu command lines from this readme.txt file, by having a
> -append option similar to the ones used in other readme.txt files.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> board/qemu/x86/readme.txt | 2 +-
> board/qemu/x86_64/readme.txt | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/qemu/x86/readme.txt b/board/qemu/x86/readme.txt
> index 17500961d3..b003ad5373 100644
> --- a/board/qemu/x86/readme.txt
> +++ b/board/qemu/x86/readme.txt
> @@ -1,6 +1,6 @@
> Run the emulation with:
>
> - qemu-system-i386 -M pc -kernel output/images/bzImage -drive file=output/images/rootfs.ext2,if=virtio,format=raw -append root=/dev/vda -net nic,model=virtio -net user
> + qemu-system-i386 -M pc -kernel output/images/bzImage -drive file=output/images/rootfs.ext2,if=virtio,format=raw -append "root=/dev/vda" -net nic,model=virtio -net user
>
> Optionally add -smp N to emulate a SMP system with N CPUs.
>
> diff --git a/board/qemu/x86_64/readme.txt b/board/qemu/x86_64/readme.txt
> index ecd7813a1e..ed7b5f5532 100644
> --- a/board/qemu/x86_64/readme.txt
> +++ b/board/qemu/x86_64/readme.txt
> @@ -1,6 +1,6 @@
> Run the emulation with:
>
> - qemu-system-x86_64 -M pc -kernel output/images/bzImage -drive file=output/images/rootfs.ext2,if=virtio,format=raw -append root=/dev/vda -net nic,model=virtio -net user
> + qemu-system-x86_64 -M pc -kernel output/images/bzImage -drive file=output/images/rootfs.ext2,if=virtio,format=raw -append "root=/dev/vda" -net nic,model=virtio -net user
>
> Optionally add -smp N to emulate a SMP system with N CPUs.
>
> --
> 2.13.6
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-11-27 20:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 8:08 [Buildroot] [PATCH 1/2] board/qemu/ppc64-pseries: adjust Qemu command line Thomas Petazzoni
2017-11-21 8:08 ` [Buildroot] [PATCH 2/2] board/qemu/x86*: use quotes around -append Qemu option value Thomas Petazzoni
2017-11-27 20:56 ` Yann E. MORIN [this message]
2017-11-27 20:56 ` [Buildroot] [PATCH 1/2] board/qemu/ppc64-pseries: adjust Qemu command line Yann E. MORIN
2017-11-27 21:38 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127205637.GJ2950@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox