From: Andrey Yurovsky <yurovsky@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/scripts/size-stats: avoid divide-by-zero
Date: Mon, 27 Nov 2017 19:37:07 -0800 [thread overview]
Message-ID: <20171128033707.15072-1-yurovsky@gmail.com> (raw)
In-Reply-To: <20171127220849.5f62e6fc@windsurf.home>
Some packages (ex: skeleton-init-systemd) have a zero size so we cannot
divide by the package size. In that case make their percent zero
explicitly and avoid a ZeroDivisionError exception.
Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>
---
support/scripts/size-stats | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/support/scripts/size-stats b/support/scripts/size-stats
index af45000359..3ff2a1ce18 100755
--- a/support/scripts/size-stats
+++ b/support/scripts/size-stats
@@ -178,9 +178,17 @@ def gen_files_csv(filesdict, pkgsizes, outputf):
"File size in system (%)"])
for f, (pkgname, filesize) in filesdict.items():
pkgsize = pkgsizes[pkgname]
+
+ if pkgsize == 0:
+ percent_pkg = 0
+ else:
+ percent_pkg = float(filesize) / pkgsize * 100
+
+ percent_total = float(filesize) / total * 100
+
wr.writerow([f, pkgname, filesize, pkgsize,
- "%.1f" % (float(filesize) / pkgsize * 100),
- "%.1f" % (float(filesize) / total * 100)])
+ "%.1f" % percent_pkg,
+ "%.1f" % percent_total])
#
--
2.14.3
next prev parent reply other threads:[~2017-11-28 3:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 2:17 [Buildroot] potential divide by zero in support/scripts/size-stats Andrey Yurovsky
2017-11-27 21:08 ` Thomas Petazzoni
2017-11-28 3:37 ` Andrey Yurovsky [this message]
2017-11-28 10:09 ` [Buildroot] [PATCH] support/scripts/size-stats: avoid divide-by-zero Yann E. MORIN
2017-11-29 20:36 ` Thomas Petazzoni
2017-12-20 20:52 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128033707.15072-1-yurovsky@gmail.com \
--to=yurovsky@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox