Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3 v3] zlib-ng: new package
Date: Wed, 29 Nov 2017 10:44:01 +0100	[thread overview]
Message-ID: <20171129104401.49254392@windsurf.home> (raw)
In-Reply-To: <20171128232936.23067-1-stefan.froberg@petroprogram.com>

Hello,

Thanks for this new iteration!

On Wed, 29 Nov 2017 01:29:34 +0200, Stefan Fr?berg wrote:
> Signed-off-by: Stefan Fr?berg <stefan.froberg@petroprogram.com>
> 
> Changes v2 -> v3:
> 
> - Add myself to DEVELOPERS files (by Thomas).
> - Update github download url.
> - Keep only sha256 of the locally computed hashes.
> - Add few cmake switches and also check for ARM support.
> - Convert to use virtual package infrastructure (by Thomas).

Changes should go after the --- mark, i.e...

> 
> ---

... here.

However, there's a bigger problem with your series: it's not bisectable.

If I apply just PATCH 1/3, then zlib-ng is available, but will
conflict/overwrite files installs by zlib. Not good.

If I apply just PATCH 1/3 and PATCH 2/3, then all packages that use
zlib are broken because it's now called libzlib.

So basically, you need to squash PATCH 2/3 and 3/3 into a single patch,
and make that the first patch of the series (of course removing the
zlib-ng support in it).

And then as a second patch, introduce the zlib-ng package, as a new
provider for zlib.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      parent reply	other threads:[~2017-11-29  9:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 23:29 [Buildroot] [PATCH 1/3 v3] zlib-ng: new package Stefan Fröberg
2017-11-28 23:29 ` [Buildroot] [PATCH 2/3 v3] rename zlib to libzlib Stefan Fröberg
2017-11-28 23:29 ` [Buildroot] [PATCH 3/3 v3] zlib-ng: make zlib a virtual package Stefan Fröberg
2017-11-29  9:44 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171129104401.49254392@windsurf.home \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox