[Buildroot] [PATCH 2/2] android-tools: upport char, block, fifo, socket devices

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

Thanks for your contributions! See below for a few comments/questions.

On Thu, 30 Nov 2017 12:56:31 -0800, Keith Mok wrote:
> Pick changes from openwrt to enable support of special
> device for make_ext4fs

Missing Signed-off-by line.

> ---
>  ...ment-support-for-block-and-char-dev-nodes.patch | 109 +++++++++++++++++++++
>  1 file changed, 109 insertions(+)
>  create mode 100644 package/android-tools/0009-PATCH-Implement-support-for-block-and-char-dev-nodes.patch
> 
> diff --git a/package/android-tools/0009-PATCH-Implement-support-for-block-and-char-dev-nodes.patch b/package/android-tools/0009-PATCH-Implement-support-for-block-and-char-dev-nodes.patch
> new file mode 100644
> index 0000000..e86d9c6
> --- /dev/null
> +++ b/package/android-tools/0009-PATCH-Implement-support-for-block-and-char-dev-nodes.patch
> @@ -0,0 +1,109 @@
> +From 3258b175c3ea1f76823c6b69b5036ac7efb5599d Mon Sep 17 00:00:00 2001
> +From: Jo-Philipp Wich <jow@openwrt.org>
> +Date: Thu, 30 Nov 2017 10:10:24 -0800
> +Subject: [PATCH] [PATCH] Implement support for block and char dev nodes, fifos
> + and sockets.
> +
> +Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>
> +Signed-off-by: Keith Mok <ek9852@gmail.com>

This really is a feature patch, and we don't like to take features
patches in Buildroot (unlike OpenWRT). Indeed, those are often a pain
to maintain over time.

Do you see any possibility of this being merged upstream? I do realize
that the upstream for android-tools is somewhat unusual, and that
getting contributions accepted might be more challenging than with
other open source projects. But still I'd like to hear about what has
been tried to push this upstream.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com