From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 2 Dec 2017 15:08:09 +0100 Subject: [Buildroot] [PATCH 1/1] check-package: avoid false warning of useless flag In-Reply-To: <20171202135443.GB2988@scaer> References: <1512188904-31366-1-git-send-email-ricardo.martincoski@datacom.ind.br> <20171202110320.GA2988@scaer> <20171202141059.391df6c0@windsurf.lan> <20171202135443.GB2988@scaer> Message-ID: <20171202150809.1140da1b@windsurf.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Sat, 2 Dec 2017 14:54:43 +0100, Yann E. MORIN wrote: > OK, but then with this change, we will now be missing actual errors, > e.g.: > > FOO_AUTORECONF = NO > HOST_FOO_AUTORECONF = NO > > Will not report the host vairant as bogus, even after the target variant > gets removed. > > So we lose a false positive for a false negative. Yes, it was already mentioned by Ricardo in the discussion. > I have to admit I am not sure which is worse/best... Checking tools that have false positives are unusable, because they create some noise that always make you think "gaah, it must be the tool again complaining about something that doesn't make sense". So I very much prefer a tool that doesn't report false positives, and for which the results can be trusted. This way, we are much more likely to pay attention to the tool results, and keep in a good shape what the tool is checking today. And that doesn't prevent, in parallel, from improving the tool to detect other problems. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com