Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] board/orangepi: add support for orangepi-pc-plus board
Date: Sun, 3 Dec 2017 23:25:28 +0100	[thread overview]
Message-ID: <20171203232528.237e3ec3@windsurf.home> (raw)
In-Reply-To: <20171108194334.10031-2-geomatsi@gmail.com>

Hello,

On Wed,  8 Nov 2017 22:43:32 +0300, Sergey Matyukevich wrote:
> This board is a variant of orangepi-pc board. It adds 8GB eMMC and Realtek
> RTL8189FTV SDIO WiFi chip. This variant has a separate support in U-Boot
> and kernel. So it makes sense to create a separate entry
> for this board in buildroot.
> 
> Board support package includes the following components:
>  - mainline u-boot 2017.09
>  - mainline kernel 4.13.11
> 
> Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>

I've applied, after adding an entry to the DEVELOPERS file. One
comment, though.

>  board/orangepi/orangepi-pc-plus/boot.cmd           |  8 +++++
>  board/orangepi/orangepi-pc-plus/genimage.cfg       | 36 ++++++++++++++++++++
>  .../orangepi/orangepi-pc-plus/linux-extras.config  |  8 +++++
>  board/orangepi/orangepi-pc-plus/post-build.sh      |  1 +

This common post-build script only generates the U-Boot script. Could
you move the boards that use this post-build script to instead use
BR2_TARGET_UBOOT_BOOT_SCRIPT ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-12-03 22:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08 19:43 [Buildroot] [PATCH 0/3] orangepi_pc_plus: new board and its drivers Sergey Matyukevich
2017-11-08 19:43 ` [Buildroot] [PATCH 1/3] board/orangepi: add support for orangepi-pc-plus board Sergey Matyukevich
2017-12-03 22:25   ` Thomas Petazzoni [this message]
2017-12-04  5:58     ` Sergey Matyukevich
2017-11-08 19:43 ` [Buildroot] [PATCH 2/3] rtl8189fs: new package Sergey Matyukevich
2017-12-03 22:28   ` Thomas Petazzoni
2017-11-08 19:43 ` [Buildroot] [PATCH 3/3] orangepi-pc-plus: enable WiFi support Sergey Matyukevich
2017-12-03 22:33   ` Thomas Petazzoni
2017-12-04  4:25   ` Jagan Teki
2017-12-04  7:59     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171203232528.237e3ec3@windsurf.home \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox