From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] traceroute: new package
Date: Sat, 16 Dec 2017 16:06:36 +0100 [thread overview]
Message-ID: <20171216160636.028739fe@windsurf> (raw)
In-Reply-To: <1513429309-16761-1-git-send-email-sergio.prado@e-labworks.com>
Hello,
On Sat, 16 Dec 2017 11:01:49 -0200, Sergio Prado wrote:
> +define TRACEROUTE_INSTALL_TARGET_CMDS
> + $(RM) -f $(TARGET_DIR)/usr/bin/traceroute
I didn't see why this is needed. The package does a simple "cp", so
reinstallation works fine. So I've dropped this.
> + $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> + prefix=$(TARGET_DIR)/usr install -C $(@D)
This value of prefix is not really correct. A more correct approach is
DESTDIR=$(TARGET_DIR) prefix=/usr. Even though it changes nothing in
practice for this package, it is more consistent with what we do in
other packages (and what is technically correct).
Applied with those changes. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-12-16 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 13:01 [Buildroot] [PATCH] traceroute: new package Sergio Prado
2017-12-16 15:06 ` Thomas Petazzoni [this message]
2017-12-16 21:47 ` Peter Korsgaard
2017-12-17 9:08 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171216160636.028739fe@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox