From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] pimd: new package
Date: Sat, 16 Dec 2017 16:32:59 +0100 [thread overview]
Message-ID: <20171216163259.58bf6b3b@windsurf> (raw)
In-Reply-To: <1513030661-3370-1-git-send-email-sergio.prado@e-labworks.com>
Hello,
On Mon, 11 Dec 2017 20:17:41 -0200, Sergio Prado wrote:
> +PIMD_VERSION = 2.3.2
> +PIMD_SOURCE = pimd-$(PIMD_VERSION).tar.gz
> +PIMD_SITE = https://github.com/troglobit/pimd/releases/download/$(PIMD_VERSION)
> +
> +PIMD_LICENSE = BSD-3-Clause
> +PIMD_LICENSE_FILES = LICENSE LICENSE.mrouted
> +
> +PIMD_MAKE_OPTS = CROSS=$(TARGET_CROSS) CC=$(TARGET_CC)
This variable was not really needed, since it's used only once, so I've
used CROSS and CC directly in BUILD_CMDS.
> +
> +ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_TOOLCHAIN_USES_MUSL),y)
> +PIMD_CONF_OPTS = --embedded-libc
I've used += here instead of =, since we're inside a condition. This
typically avoids mistakes in the future.
> +define PIMD_INSTALL_TARGET_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
> +endef
This was incorrectly installing in $(TARGET_DIR)/usr/local, so I've
added prefix=/usr to fix that. I've also dropped the quotes around
"$(TARGET_DIR)" since we don't do it in general in Buildroot.
Applied with those changes. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-12-16 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 22:17 [Buildroot] [PATCH v3] pimd: new package Sergio Prado
2017-12-16 15:32 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171216163259.58bf6b3b@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox