From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] utils/checkpackagelib: exclude two files from Config.in indentation check
Date: Wed, 20 Dec 2017 09:10:53 +0100 [thread overview]
Message-ID: <20171220091053.6a760beb@windsurf.lan> (raw)
In-Reply-To: <5a39a17460729_111111ac5882144b@ultri3.mail>
Hello,
On Tue, 19 Dec 2017 21:32:04 -0200, Ricardo Martincoski wrote:
> Thank you for explaining (in the other e-mail) the reasoning of the special
> indentation.
>
>
> One last thought about the code...
>
> Until now the script can be called passing relative or absolute filenames to
> check. These 3 commands have the same result:
> $ ./utils/check-package $(find $(readlink -f package) -type f) >/dev/null
> $ ./utils/check-package $(find package -type f) >/dev/null
> $ ./utils/check-package $(find ./package -type f) >/dev/null
>
> To keep this behavior we could use instead:
> if self.filename.endswith("package/x11r7/Config.in") or \
> self.filename.endswith("package/kodi/Config.in"):
> or its equivalent in one line (it fits in 132).
Sure, makes sense.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-12-20 8:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 8:43 [Buildroot] [PATCH] utils/checkpackagelib: exclude two files from Config.in indentation check Thomas Petazzoni
2017-12-18 22:03 ` Yann E. MORIN
2017-12-19 1:57 ` Ricardo Martincoski
2017-12-19 5:33 ` Bernd Kuhls
2017-12-19 8:28 ` Thomas Petazzoni
2017-12-20 11:06 ` Yann E. MORIN
2017-12-19 1:56 ` Ricardo Martincoski
2017-12-19 8:36 ` Thomas Petazzoni
2017-12-19 23:32 ` Ricardo Martincoski
2017-12-20 8:10 ` Thomas Petazzoni [this message]
2018-03-22 3:20 ` Ricardo Martincoski
2018-03-22 8:18 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220091053.6a760beb@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox