From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] libdrm-armada: new package
Date: Wed, 20 Dec 2017 16:23:54 +0100 [thread overview]
Message-ID: <20171220162354.21092f36@windsurf.lan> (raw)
In-Reply-To: <20171220150843.21154-2-didin@synopsys.com>
Hello,
(In addition to the comments from Yann).
On Wed, 20 Dec 2017 18:08:42 +0300, Evgeniy Didin wrote:
> package/Config.in | 1 +
> package/libdrm-armada/Config.in | 7 +++++++
> package/libdrm-armada/libdrm-armada.hash | 2 ++
> package/libdrm-armada/libdrm-armada.mk | 24 ++++++++++++++++++++++++
Entry in DEVELOPERS file missing.
> +LIBDRM_ARMADA_VERSION = 6b461c
Please use a full Git hash.
> +LIBDRM_ARMADA_SOURCE = libdrm-armada-$(LIBDRM_ARMADA_VERSION).tar.gz
> +LIBDRM_ARMADA_SITE = http://git.arm.linux.org.uk/cgit/libdrm-armada.git
> +LIBDRM_ARMADA_SITE_METHOD = git
> +LIBDRM_ARMADA_DEPENDENCIES = libdrm
> +LIBDRM_ARMADA_INSTALL_STAGING = YES
It is a problem that this package has no license information
whatsoever. No COPYING file, no LICENSE file, no header in the source
file that indicates the license (except for
http://git.arm.linux.org.uk/cgit/libdrm-armada.git/tree/libdrm_lists.h).
Could you ask upstream to add appropriate licensing information ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-12-20 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 15:08 [Buildroot] [PATCH 0/2] Xorg: enable Etnaviv support Evgeniy Didin
2017-12-20 15:08 ` [Buildroot] [PATCH 1/2] libdrm-armada: new package Evgeniy Didin
2017-12-20 15:16 ` Yann E. MORIN
2017-12-20 16:22 ` Evgeniy Didin
2017-12-20 15:23 ` Thomas Petazzoni [this message]
2017-12-20 16:29 ` Evgeniy Didin
2017-12-20 16:35 ` Fabio Estevam
2017-12-20 17:02 ` Evgeniy Didin
2017-12-20 15:08 ` [Buildroot] [PATCH 2/2] xf86-video-armada: " Evgeniy Didin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220162354.21092f36@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox