From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Thu, 28 Dec 2017 14:24:22 +0100
Subject: [Buildroot] [PATCH] package/nut: workaround parallel build issue
In-Reply-To: <87tvwduxml.fsf@dell.be.48ers.dk>
References: <20171223152911.12640-1-yann.morin.1998@free.fr>
 <87tvwduxml.fsf@dell.be.48ers.dk>
Message-ID: <20171228132422.GC3428@scaer>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

On 2017-12-26 19:56 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> 
>  > The conditions are not trivial to reproduce, but it can happen that the
>  > headers are not fully regenerated by the time they are included.
> 
>  > Since they already are present and current in the archive, just patch
>  > out their generation from the Makefile.
> 
>  > Fixes:
>  >     http://autobuild.buildroot.org/results/523/5231ff39a0839ec5e1962662004214d4b0773068/
>  >     http://autobuild.buildroot.org/results/5a7/5a75d44c028e77b58f0fd9ab794952f2b477dd84/
> 
>  > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Thanks, but doesn't it make more sense to just use MAKE1 instead of such
> a non-upstreamable patch?
> 
> Nut is not a very big package and has no reverse dependencies, so the
> impact of MAKE1 is quite small.

I timed a nut build, and indeed the build time for a non-parallel build
is split as such (on an otherwise-unloaded machine):

    14:18:03 >>> nut 2.7.4 Extracting
    14:18:03 >>> nut 2.7.4 Patching
    14:18:03 >>> nut 2.7.4 Updating config.sub and config.guess
    14:18:03 >>> nut 2.7.4 Configuring
    14:18:03 >>> nut 2.7.4 Autoreconfiguring
    14:18:10 >>> nut 2.7.4 Patching libtool
    14:18:15 >>> nut 2.7.4 Building
    14:18:37 >>> nut 2.7.4 Installing to target

So it is about 34s, of which 22s to build, while a parallel build would
take just about 8s to build.

I'll send a patch to use MAKE1.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'