From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Thu, 28 Dec 2017 23:25:39 +0100
Subject: [Buildroot] [PATCH v4 2/2] docs/manual: document meson-based
 packages
In-Reply-To: <20171228232210.5dda9865@windsurf>
References: <20171029131052.18850-1-eric.le.bihan.dev@free.fr>
 <20171029131052.18850-3-eric.le.bihan.dev@free.fr>
 <20171228232210.5dda9865@windsurf>
Message-ID: <20171228222539.GH3428@scaer>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Thomas, All,

On 2017-12-28 23:22 +0100, Thomas Petazzoni spake thusly:
> On Sun, 29 Oct 2017 14:10:52 +0100, Eric Le Bihan wrote:
> > Add instructions for adding a package which uses the Meson build system.
> > 
> > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> > Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> 
> I've applied to the master branch, after adding an entry in the
> DEVELOPERS file. I also have one comment/question below.
> 
> 
> > +27: define FOO_CONFIGURE_CMDS
> > +28: 	rm -rf $(@D)/build
> > +29: 	mkdir -p $(@D)/build
> 
> Is this really needed? It's not really nice to have to do this. But
> perhaps meson really insists in having an empty build directory ?

IIRC, I made the same comment in a  previous iteration of this patch, and
yes, meson really insists on having an empty build directory, otherwise it
fails loudly... :-/

This should have been part of the commit log *and* should be clearly
stated in the manual that this is required.

Regards,
Yann E. MORIN.

> Thanks!
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'