Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] package/brltty: explicitly check if ioperm is available
Date: Fri, 29 Dec 2017 20:54:55 +0100	[thread overview]
Message-ID: <20171229205455.561578ef@windsurf.lan> (raw)
In-Reply-To: <87o9mh9w5t.fsf@home.blind.guru>

Hello,

On Fri, 29 Dec 2017 20:22:22 +0100, Mario Lang wrote:

> > This seems weird. What happens then when ioperm() is not available ?
> > Which ports_package is used ?  
> 
> "none", which is exactly what we want.  Patch already accepted by upstream.
> The "ports package" is to support Braille displays connected via the
> parallel port, which basically no longer exist these days.  All relevant
> models work via USB, Bluetooth or plain serial ports these days.
> 
> >> -BRLTTY_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
> >> +BRLTTY_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) host-autoconf
> >>  
> >>  BRLTTY_CONF_OPTS = \
> >>  	--disable-java-bindings \
> >> @@ -24,6 +24,12 @@ BRLTTY_CONF_OPTS = \
> >>  	--without-mikropuhe --without-speechd --without-swift \
> >>  	--without-theta --without-viavoice
> >>  
> >> +define BRLTTY_AUTOCONF
> >> +	cd $(BRLTTY_SRCDIR) && $(AUTOCONF)
> >> +endef
> >> +
> >> +BRLTTY_PRE_CONFIGURE_HOOKS += BRLTTY_AUTOCONF  
> >
> > Please use BRLTTY_AUTORECONF = YES instead.  
> 
> brltty doesn't work with autoreconf.  It has its own autogen script,
> which basically does some dependency calculations (with tcl, a dep I'd
> like to avoid) and a plain autoconf.  So I copied that behaviour, since
> autoreconf fails with problems about autoheaders.

OK, thanks for those explanations!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-12-29 19:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-29 14:06 [Buildroot] [PATCH v2 1/2] package/brltty: avoid spurious log messages while decoding scancodes Mario Lang
2017-12-29 14:06 ` [Buildroot] [PATCH v2 2/2] package/brltty: explicitly check if ioperm is available Mario Lang
2017-12-29 16:19   ` Thomas Petazzoni
2017-12-29 19:22     ` Mario Lang
2017-12-29 19:54       ` Thomas Petazzoni [this message]
2017-12-29 20:59   ` Thomas Petazzoni
2017-12-29 20:56 ` [Buildroot] [PATCH v2 1/2] package/brltty: avoid spurious log messages while decoding scancodes Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171229205455.561578ef@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox