From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] nginx: Harden patches for using pkg-config
Date: Fri, 29 Dec 2017 23:35:04 +0100 [thread overview]
Message-ID: <20171229233504.504d9802@windsurf.lan> (raw)
In-Reply-To: <20171219125903.pbudek3j6lsr6hje@zenon.in.qult.net>
Hello,
On Tue, 19 Dec 2017 13:59:04 +0100, Ignacy Gaw?dzki wrote:
> On Tue, Dec 19, 2017 at 01:43:16PM +0100, thus spake Thomas Petazzoni:
> > Hello,
> >
> > On Tue, 19 Dec 2017 11:10:24 +0100, Ignacy Gaw?dzki wrote:
> > > Don't simply remove "-I" from the output of pkg-config --cflags-only-I
> > > but match the -I argument more generally.
> >
> > OK, but why? What is this fixing?
>
> Suppose that the lib has been installed in /usr/Some-Install-Location/
> then pkg-config --cflags-only-I may return
>
> -I/usr/Some-Install-Location/include
>
> which, piped through sed 's/-I//g' would end up being
>
> /usr/Somenstall-Location/include
>
> which is probably not going to work.
Indeed, makes total sense. I've applied your patch, after rewording the
commit log to be clearer about what is being fixed. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-12-29 22:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 22:59 [Buildroot] [PATCH 1/1] nginx: Harden patches for using pkg-config Ignacy Gawędzki
2017-12-19 10:10 ` [Buildroot] [PATCH v2 0/1] " Ignacy Gawędzki
2017-12-19 10:10 ` [Buildroot] [PATCH v2 1/1] " Ignacy Gawędzki
2017-12-19 12:43 ` Thomas Petazzoni
2017-12-19 12:59 ` Ignacy Gawędzki
2017-12-29 22:35 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171229233504.504d9802@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox