Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] daq: new package
Date: Sat, 30 Dec 2017 21:18:22 +0100	[thread overview]
Message-ID: <20171230211822.7967e315@windsurf> (raw)
In-Reply-To: <1514150285-19871-1-git-send-email-sergio.prado@e-labworks.com>

Hello,

On Sun, 24 Dec 2017 19:18:05 -0200, Sergio Prado wrote:
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>

Thanks, I've applied, after doing a few changes. See below.

> diff --git a/package/daq/Config.in b/package/daq/Config.in
> new file mode 100644
> index 000000000000..0627274b52ad
> --- /dev/null
> +++ b/package/daq/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_DAQ
> +	bool "daq"
> +	select BR2_PACKAGE_LIBPCAP
> +	select BR2_PACKAGE_LIBDNET
> +	depends on !BR2_STATIC_LIBS # dlfcn.h

By convention, "depends on" lines go before "select" lines. This is
verified by check-package.

> diff --git a/package/daq/daq.mk b/package/daq/daq.mk
> new file mode 100644
> index 000000000000..f10c31d4a157
> --- /dev/null
> +++ b/package/daq/daq.mk
> @@ -0,0 +1,26 @@
> +################################################################################
> +#
> +# daq
> +#
> +################################################################################
> +
> +DAQ_VERSION = 2.0.6
> +DAQ_SITE = https://www.snort.org/downloads/snort
> +DAQ_SOURCE = daq-$(DAQ_VERSION).tar.gz
> +
> +DAQ_LICENSE = GPL-2.0
> +DAQ_LICENSE_FILES = COPYING

Since it's a library, it felt weird to not have DAQ_INSTALL_STAGING =
YES, so I've added that.

> +# assume these flags are available to prevent configure from
> +# running test programs while cross compiling
> +DAQ_CONF_ENV = \
> +	ac_cv_lib_pcap_pcap_lib_version="yes" \
> +	daq_cv_libpcap_version_1x="yes"

The double quotes around the "yes" were not needed, and we don't do
that elsewhere in Buildroot, so I've dropped them.

Applied with those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-12-30 20:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-24 21:18 [Buildroot] [PATCH] daq: new package Sergio Prado
2017-12-30 20:18 ` Thomas Petazzoni [this message]
2017-12-31 12:22   ` Sergio Prado
2018-01-03 14:15     ` Matthew Weber
2018-01-03 15:40       ` Matthew Weber
2018-01-03 17:13         ` Sergio Prado
2018-01-03 16:56       ` Sergio Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171230211822.7967e315@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox