From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 30 Dec 2017 22:46:28 +0100 Subject: [Buildroot] [PATCH v2 1/2] Opentracing: add opentracing-cpp v1.2.0 package In-Reply-To: <1514014802-23736-2-git-send-email-heyleke@gmail.com> References: <1513849309-550-2-git-send-email-heyleke@gmail.com> <1514014802-23736-1-git-send-email-heyleke@gmail.com> <1514014802-23736-2-git-send-email-heyleke@gmail.com> Message-ID: <20171230224628.746682f5@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Sat, 23 Dec 2017 08:40:01 +0100, Jan Heylen wrote: > From: Jan Heylen > > Signed-off-by: Jan Heylen The commit title should be: opentracing-cpp: new package > package/Config.in | 1 + > package/opentracing-cpp/Config.in | 11 +++++++++++ > package/opentracing-cpp/opentracing-cpp.hash | 3 +++ > package/opentracing-cpp/opentracing-cpp.mk | 14 ++++++++++++++ Please add an entry in the DEVELOPERS file for this package. > diff --git a/package/opentracing-cpp/Config.in b/package/opentracing-cpp/Config.in > new file mode 100644 > index 0000000..3f6f1ad > --- /dev/null > +++ b/package/opentracing-cpp/Config.in > @@ -0,0 +1,11 @@ > +config BR2_PACKAGE_OPENTRACING_CPP > + bool "opentracing-cpp" > + depends on BR2_INSTALL_LIBSTDCPP > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11 > + help > + OpenTracing API for C++ > + > + http://opentracing.io > + > +comment "opentracing-cpp needs a toolchain w/ C++" > + depends on !BR2_INSTALL_LIBSTDCPP You forgot to include in the comment the gcc >= 4.8 dependency. Also, this package doesn't build with the following defconfig: BR2_arm=y BR2_TOOLCHAIN_EXTERNAL=y BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2017.11-rc1.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_10=y BR2_TOOLCHAIN_EXTERNAL_LOCALE=y # BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set BR2_TOOLCHAIN_EXTERNAL_CXX=y BR2_INIT_NONE=y BR2_SYSTEM_BIN_SH_NONE=y # BR2_PACKAGE_BUSYBOX is not set BR2_PACKAGE_OPENTRACING_CPP=y # BR2_TARGET_ROOTFS_TAR is not set It fails with: >>> opentracing-cpp v1.2.0 Building PATH="/home/thomas/projets/buildroot/output/host/bin:/home/thomas/projets/buildroot/output/host/sbin:/usr/local/bin:/usr/bin:/bin:/home/thomas/.rvm/bin:/usr/local/sbin:/usr/sbin:/home/thomas/.rvm/bin:/home/thomas/sys/bin:/home/thomas/.gem/ruby/2.1.0/bin:/home/thomas/.rvm/bin" /usr/bin/make -j5 -C /home/thomas/projets/buildroot/output/build/opentracing-cpp-v1.2.0/ Scanning dependencies of target opentracing [ 25%] Building CXX object CMakeFiles/opentracing.dir/src/tracer.cpp.o [ 75%] Building CXX object CMakeFiles/opentracing.dir/src/propagation.cpp.o [ 75%] Building CXX object CMakeFiles/opentracing.dir/src/noop.cpp.o In file included from /home/thomas/projets/buildroot/output/build/opentracing-cpp-v1.2.0/include/opentracing/util.h:13:0, from /home/thomas/projets/buildroot/output/build/opentracing-cpp-v1.2.0/include/opentracing/propagation.h:5, from /home/thomas/projets/buildroot/output/build/opentracing-cpp-v1.2.0/include/opentracing/tracer.h:4, from /home/thomas/projets/buildroot/output/build/opentracing-cpp-v1.2.0/include/opentracing/noop.h:4, from /home/thomas/projets/buildroot/output/build/opentracing-cpp-v1.2.0/src/noop.cpp:1: /home/thomas/projets/buildroot/output/build/opentracing-cpp-v1.2.0/3rd_party/include/opentracing/expected/expected.hpp:230:24: error: ?exception_ptr? is not a member of ?std? class unexpected_type< std::exception_ptr > ^ /home/thomas/projets/buildroot/output/build/opentracing-cpp-v1.2.0/3rd_party/include/opentracing/expected/expected.hpp:230:24: error: ?exception_ptr? is not a member of ?std? /home/thomas/projets/buildroot/output/build/opentracing-cpp-v1.2.0/3rd_party/include/opentracing/expected/expected.hpp:230:43: error: template argument 1 is invalid class unexpected_type< std::exception_ptr > ^ and many more of such errors. Could you verify with ./utils/test-pkg that your package builds properly? Thanks a lot! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com