Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] gconf: new package
Date: Mon, 1 Jan 2018 12:34:14 +0100	[thread overview]
Message-ID: <20180101123414.49e3b498@windsurf> (raw)
In-Reply-To: <20171121020258.31523-1-joseph.kogut@gmail.com>

Hello,

On Mon, 20 Nov 2017 18:02:58 -0800, Joseph Kogut wrote:
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> ---
>  DEVELOPERS               |  1 +
>  package/Config.in        |  1 +
>  package/gconf/Config.in  | 10 ++++++++++
>  package/gconf/gconf.hash |  4 ++++
>  package/gconf/gconf.mk   | 10 ++++++++++
>  5 files changed, 26 insertions(+)
>  create mode 100644 package/gconf/Config.in
>  create mode 100644 package/gconf/gconf.hash
>  create mode 100644 package/gconf/gconf.mk

Thanks for your contribution. I've applied, after fixing a number of
issues:

    [Thomas:
     - propagate dependencies of selected packages in Config.in
     - add missing Config.in comment about dependencies
     - add missing upstream URL in Config.in
     - add missing comment header in .mk file
     - remove --disable-nls from configuration options, it is taken care
       of by the package infrastructure
     - remove --disable-dependency-tracking, it is taken care of in the
       package infrastructure
     - add $(TARGET_NLS_DEPENDENCIES) to <pkg>_DEPENDENCIES, since gconf
       has optional NLS support
     - add host-intltool to <pkg>_DEPENDENCIES, since gconf needs
       intltool-update
     - fix license: it's LGPL-2.0+, not GPL-2.0.]

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2018-01-01 11:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-21  2:02 [Buildroot] [PATCH 1/1] gconf: new package Joseph Kogut
2017-12-02 15:34 ` Marcus Folkesson
2018-01-01 11:34 ` Thomas Petazzoni [this message]
2018-01-01 12:05   ` Joseph Kogut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180101123414.49e3b498@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox