Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] scanpypi: get license names from SPDX database
Date: Mon, 1 Jan 2018 12:50:26 +0100	[thread overview]
Message-ID: <20180101125026.0c7d7722@windsurf> (raw)
In-Reply-To: <20171114105856.2077-1-yegorslists@googlemail.com>

Hello,

On Tue, 14 Nov 2017 11:58:56 +0100, yegorslists at googlemail.com wrote:

> +try:
> +    import spdx_lookup as liclookup
> +except ImportError:
> +    # spdx_lookup is not installed
> +    liclookup = None
> +

I understand the idea, but I find it a bit weird to have the script
behave differently depending on whether we have the SDPX Python package
installed or not. Indeed, it may return different license results.

Should we at the very least display a warning when the SDPX package is
not there? Or should we have an option to explicitly select if the SDPX
package should be used or not?

I don't have a strong opinion on this, so if you (and others) believe
that your proposal is good enough, then I'm fine with it.

>          filenames = ['LICENCE', 'LICENSE', 'LICENSE.RST', 'LICENSE.TXT',
> -		     'COPYING', 'COPYING.TXT']
> +                     'COPYING', 'COPYING.TXT']

This is a spurious and not really related change :)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2018-01-01 11:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14 10:58 [Buildroot] [PATCH] scanpypi: get license names from SPDX database yegorslists at googlemail.com
2018-01-01 11:50 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180101125026.0c7d7722@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox