From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] core/tests: add test for compressed iso9660
Date: Mon, 1 Jan 2018 14:05:56 +0100 [thread overview]
Message-ID: <20180101130556.GA24931@scaer> (raw)
In-Reply-To: <20171231182302.59012b3f@windsurf>
Thomas, All,
On 2017-12-31 18:23 +0100, Thomas Petazzoni spake thusly:
> On Wed, 20 Dec 2017 22:27:43 +0100, Yann E. MORIN wrote:
> > +class TestIso9660Grub2ExternalCompress(infra.basetest.BRTest):
> > + config = BASIC_CONFIG + \
> > + """
> > + BR2_TARGET_ROOTFS_ISO9660=y
> > + # BR2_TARGET_ROOTFS_ISO9660_INITRD is not set
> > + BR2_TARGET_ROOTFS_ISO9660_TRANSP_COMPRESS
> Not sure you really tested with transparent compression enabled, since
> =y was missing. So I've fixed that, taken into account the option
> rename, and applied. Thanks!
I'm pretty sure that got tested:
https://gitlab.com/ymorin/buildroot-ci/pipelines/15356311
But it proabably got ignored, so the filesystem was not compression
enabled.
Thanks for the fix.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2018-01-01 13:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 21:27 [Buildroot] [PATCH 0/2] fs/iso9660: add transparent compression Yann E. MORIN
2017-12-20 21:27 ` [Buildroot] [PATCH 1/2] fs/iso9660: add option for transparent (de)compression Yann E. MORIN
2017-12-31 17:22 ` Thomas Petazzoni
2017-12-20 21:27 ` [Buildroot] [PATCH 2/2] core/tests: add test for compressed iso9660 Yann E. MORIN
2017-12-31 17:23 ` Thomas Petazzoni
2018-01-01 13:05 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180101130556.GA24931@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox