From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] eeprog: remove package
Date: Mon, 1 Jan 2018 23:03:37 +0100 [thread overview]
Message-ID: <20180101230337.213a84e9@windsurf> (raw)
In-Reply-To: <39d02849d93281d09a8dace211b69df3e925b43e.1514832012.git.baruch@tkos.co.il>
Hello,
On Mon, 1 Jan 2018 20:40:12 +0200, Baruch Siach wrote:
> +config BR2_PACKAGE_EEPROG
> + bool "eeprog package removed"
> + select BR2_PACKAGE_I2C_TOOLS if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
Shouldn't we instead select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS, to make
sure i2c-tools is really selected? Indeed, eeprog didn't depend on
BR2_PACKAGE_BUSYBOX_SHOW_OTHERS, so it is very possible for a user to
have BR2_PACKAGE_EEPROG=y without BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y.
Also, this should select BR2_LEGACY.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2018-01-01 22:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 18:40 [Buildroot] [PATCH] eeprog: remove package Baruch Siach
2018-01-01 22:03 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180101230337.213a84e9@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox