From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] package/meson: fix malformed cross-compilation.conf.in
Date: Mon, 1 Jan 2018 23:05:21 +0100 [thread overview]
Message-ID: <20180101230521.2c5da61c@windsurf> (raw)
In-Reply-To: <20171230095635.18123-1-yann.morin.1998@free.fr>
Hello,
On Sat, 30 Dec 2017 10:56:35 +0100, Yann E. MORIN wrote:
> Currently, meson will set the c_link_args and the cpp_link_args to the
> value of TARGET_LDFLAGS, even when it's not defined.
>
> This creates a malformed array ["",] which will break any package
> building using meson/ninja.
>
> We fix that by using an empty replacement when the corresponding values
> are empty.
>
> Reported-by: Adam Duskett <Adamduskett@outlook.com>
> Signed-off-by: Adam Duskett <Adamduskett@outlook.com>
> [yann.morin.1998 at free.fr: alternate implementation, suggested by Thomas]
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/meson/meson.mk | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2018-01-01 22:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-30 9:56 [Buildroot] [PATCHv2] package/meson: fix malformed cross-compilation.conf.in Yann E. MORIN
2017-12-31 21:04 ` Adam Duskett
2018-01-01 13:02 ` Yann E. MORIN
2018-01-01 15:17 ` Adam Duskett
2018-01-01 22:05 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180101230521.2c5da61c@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox