Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/2] opentracing-cpp: new package
Date: Wed, 3 Jan 2018 21:40:52 +0100	[thread overview]
Message-ID: <20180103214052.7e2e5499@windsurf.lan> (raw)
In-Reply-To: <1515010165-25315-3-git-send-email-heyleke@gmail.com>

Hello,

On Wed,  3 Jan 2018 21:09:25 +0100, Jan Heylen wrote:

> diff --git a/package/opentracing-cpp/Config.in b/package/opentracing-cpp/Config.in
> new file mode 100644
> index 0000000..f13d21b
> --- /dev/null
> +++ b/package/opentracing-cpp/Config.in
> @@ -0,0 +1,16 @@
> +config BR2_PACKAGE_OPENTRACING_CPP
> +	bool "opentracing-cpp"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
> +	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr
> +	depends on !BR2_m68k_cf # exception_ptr

So exception_ptr is not available on m68k coldfire, regardless of the
gcc version ?

If so, we perhaps want to introduce something like:

config BR2_TOOLCHAIN_HAS_EXECPTION_PTR
	bool
	default y
	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735
	depends on !BR2_m68k_cf

but please confirm first that there really is something special about
m68k coldfire.

> +	help
> +	  OpenTracing API for C++
> +
> +	  http://opentracing.io
> +
> +comment "opentracing-cpp needs a toolchain w/ C++11"

This should be:

	opentracing-cpp needs a toolchain w/ C++, gcc >= 4.8"

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2018-01-03 20:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03 20:09 [Buildroot] [PATCH v4 0/2] Opentracing-cpp: new package Jan Heylen
2018-01-03 20:09 ` [Buildroot] [PATCH v4 1/2] pkg-cmake: make BUILD_SHARED_LIBS part of generic cmake pkg logic Jan Heylen
2018-01-03 20:37   ` Thomas Petazzoni
2018-01-03 20:09 ` [Buildroot] [PATCH v4 2/2] opentracing-cpp: new package Jan Heylen
2018-01-03 20:40   ` Thomas Petazzoni [this message]
2018-01-05 12:57     ` Jan Heylen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180103214052.7e2e5499@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox