From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/8] python-setuptools: check host-python version
Date: Fri, 5 Jan 2018 21:29:08 +0100 [thread overview]
Message-ID: <20180105212908.7a048009@windsurf> (raw)
In-Reply-To: <1514931195.26695.184.camel@impinj.com>
Hello,
On Tue, 2 Jan 2018 22:13:15 +0000, Trent Piepho wrote:
> On Tue, 2018-01-02 at 11:33 -0500, Adam Duskett wrote:
> > python-setuptools is compatible with both python2 and python3, as such,
> > there is no need to force python2 as a dependency.
> >
> >
> > +ifeq ($(BR2_PACKAGE_HOST_PYTHON3),y)
> > +HOST_PYTHON_SETUPTOOLS_NEEDS_HOST_PYTHON += python3
> > +HOST_PYTHON_SETUPTOOLS_PYLIBVER = python$(PYTHON3_VERSION_MAJOR)
> > +else
> > +HOST_PYTHON_SETUPTOOLS_NEEDS_HOST_PYTHON += python
> > +HOST_PYTHON_SETUPTOOLS_PYLIBVER = python$(PYTHON_VERSION_MAJOR)
> > +endif
>
> From why I see in pkg-python, the default behavior for host packages is
> to depend on the default interpreter, which is python3 if enabled
> otherwise python2. Isn't the above block basically doing the same
> thing? Other than using HOST_PYTHON3 rather than PYTHON3.
>
> But shouldn't this be changed in pkg-python?
>
> Then setting <PKG>_NEEDS_HOST_PYTHON based on why python version is in
> use could be eliminated, unless the package needs a specific version,
> which appear to be how it's supposed to work.
See my reply to this patch, which explains why it is (IMO) broken.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2018-01-05 20:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 16:33 [Buildroot] [PATCH 0/8] python: clean up host version logic Adam Duskett
2018-01-02 16:33 ` [Buildroot] [PATCH 1/8] python: add selectable host entry Adam Duskett
2018-01-02 16:33 ` [Buildroot] [PATCH 2/8] python3: " Adam Duskett
2018-01-02 16:33 ` [Buildroot] [PATCH 3/8] python-setuptools: check host-python version Adam Duskett
2018-01-02 20:44 ` Thomas Petazzoni
2018-01-02 22:13 ` Trent Piepho
2018-01-05 20:29 ` Thomas Petazzoni [this message]
2018-01-09 1:47 ` Trent Piepho
2018-01-09 7:59 ` Thomas Petazzoni
2018-01-02 16:33 ` [Buildroot] [PATCH 4/8] pkg-waf.mk: " Adam Duskett
2018-01-02 16:33 ` [Buildroot] [PATCH 5/8] ninja: " Adam Duskett
2018-01-02 16:33 ` [Buildroot] [PATCH 6/8] libselinux: " Adam Duskett
2018-01-02 16:33 ` [Buildroot] [PATCH 7/8] setools: " Adam Duskett
2018-01-02 16:33 ` [Buildroot] [PATCH 8/8] libselinux: " Adam Duskett
2018-01-02 20:40 ` [Buildroot] [PATCH 0/8] python: clean up host version logic Thomas Petazzoni
2018-01-02 21:40 ` Yann E. MORIN
2018-01-02 21:44 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2018-01-02 15:27 Adam Duskett
2018-01-02 15:28 ` [Buildroot] [PATCH 3/8] python-setuptools: check host-python version Adam Duskett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105212908.7a048009@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox