From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 6 Jan 2018 15:13:08 +0100 Subject: [Buildroot] [PATCH v2 1/1] python-xlib: new package In-Reply-To: <20180105211307.25071-1-joseph.kogut@gmail.com> References: <20180105000420.20152-1-joseph.kogut@gmail.com> <20180105211307.25071-1-joseph.kogut@gmail.com> Message-ID: <20180106151308.7b5765f7@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Fri, 5 Jan 2018 13:13:07 -0800, Joseph Kogut wrote: > Thanks for the review, Yegor! > > Changes since v1: > - added runtime tag to python-six Config dependency > - remove unneeded command and newline from python-xlib.hash > - added host-python-setuptools-scm to build dependencies > - removed setup.py patch This personal message and changelog should have gone... > > Signed-off-by: Joseph Kogut > Reviewed-by: Yegor Yefremov > --- ... here, so that Git doesn't include it as part of the commit log. Indeed, we don't need to keep such details in the Git history (but they are very useful to have during the patch review process). > +PYTHON_XLIB_VERSION = 0.21 > +PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2 > +PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38 > +PYTHON_XLIB_SETUP_TYPE = setuptools > +PYTHON_XLIB_LICENSE = LGPL-2.0+ The license is in fact LGPL-2.1+, so I've fixed that and applied your patch to the master branch. Thanks for your contribution! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com