From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] toolchain: Fix toolchain to create proper builds for MIPS XBurst targets
Date: Sat, 6 Jan 2018 15:16:46 +0100 [thread overview]
Message-ID: <20180106151646.673c523c@windsurf> (raw)
In-Reply-To: <CAMbDF3KKpBcAw-03Ek3MgsLSKwP9hbuuz5KkVPBF6BSZfG-pfA@mail.gmail.com>
Hello Johannes,
On Fri, 5 Jan 2018 22:34:14 +0100, Johannes Schmitz wrote:
> It was not my own patch but I want to help bringing it up again because the
> original author complained that so far it hasn't been accepted. He
> recommended me to try it and see if it helps and it did help.
>
> Also, the commit log should explain since which gcc version is
> -mfused-madd deprecated, and since which gcc version is -ffp-contract
> available.
>
> I don't know this, my knowledge is incomplete in this area. I just manually
> applied the original patch. What can we do together to get this patch to an
> acceptable state?
Could you please send a complete patch that includes both Waldemar
changes and yours ? Also, please read the comments in
https://patchwork.ozlabs.org/patch/800406/, they pointed out the fact
that -ffp-contract only exists since gcc 4.6, so its use should be made
conditional. Read the comments from Arnout, who suggests how to address
that.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2018-01-06 14:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 16:38 [Buildroot] [PATCH 2/2] toolchain: Fix toolchain to create proper builds for MIPS XBurst targets Johannes Schmitz
2018-01-05 20:27 ` Thomas Petazzoni
2018-01-05 21:34 ` Johannes Schmitz
2018-01-06 14:16 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180106151646.673c523c@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox