From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] nilfs-utils: fix build with static toolchains
Date: Sun, 7 Jan 2018 23:29:00 +0100 [thread overview]
Message-ID: <20180107232900.63de8126@windsurf> (raw)
In-Reply-To: <1515357573-10780-1-git-send-email-dev.kurt@vandijck-laurijssen.be>
Hello,
On Sun, 7 Jan 2018 21:39:33 +0100, Kurt Van Dijck wrote:
> This commit adds a patch to respect the dependency libmount->libblkid->libuuid
> properly in autoconf. This becomes necessary for static builds.
>
> Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
Nit: when sending a new version of a patch, it is strongly recommended
to use [PATCH v2], [PATCH v3], and include a changelog...
> ---
... right here.
> +-#if HAVE_LIBMOUNT_LIBMOUNT_H
> +-#include <libmount/libmount.h>
> +-#endif /* HAVE_LIBMOUNT_H */
> ++#include <libmount.h>
> +
> + #include <stdarg.h>
> + #include <errno.h>
> +diff --git a/sbin/mount/umount_libmount.c b/sbin/mount/umount_libmount.c
> +index ae5a337..2987f5d 100644
> +--- a/sbin/mount/umount_libmount.c
> ++++ b/sbin/mount/umount_libmount.c
> +@@ -59,9 +59,7 @@
> + #include <syslog.h>
> + #endif /* HAVE_SYSLOG_H */
> +
> +-#if HAVE_LIBMOUNT_LIBMOUNT_H
> + #include <libmount/libmount.h>
> +-#endif /* HAVE_LIBMOUNT_H */
You still haven't fixed the <libmount/libmount.h> vs. <libmount.h>
discrepancy here :-)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2018-01-07 22:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 20:39 [Buildroot] [PATCH] nilfs-utils: fix build with static toolchains Kurt Van Dijck
2018-01-07 22:29 ` Thomas Petazzoni [this message]
2018-01-07 22:42 ` Thomas Petazzoni
2018-01-08 8:35 ` Kurt Van Dijck
2018-01-08 8:57 ` Thomas Petazzoni
2018-01-18 13:33 ` Thomas Petazzoni
2018-01-18 19:54 ` Kurt Van Dijck
-- strict thread matches above, loose matches on Subject: below --
2018-01-03 20:15 Kurt Van Dijck
2018-01-03 20:33 ` Thomas Petazzoni
2018-01-04 8:14 ` Kurt Van Dijck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180107232900.63de8126@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox