From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/7] package/skeleton-init-common: add /bin/sh to /etc/shells
Date: Mon, 15 Jan 2018 18:06:44 +0100 [thread overview]
Message-ID: <20180115170644.GB11122@scaer> (raw)
In-Reply-To: <87o9lvuqu0.fsf@dell.be.48ers.dk>
Peter, All,
On 2018-01-15 15:41 +0100, Peter Korsgaard spake thusly:
> >>>>> "Romain" == Romain Naour <romain.naour@smile.fr> writes:
> > Add the default shell /bin/sh to /etc/shells only if BR2_SYSTEM_BIN_SH_NONE
> > is not selected.
>
> > Add an empty /etc/shells in the rootfs skeleton.
>
> Is there any specific reason to have an empty /etc/shells?
In fact, I don't see the point of an empty one, indeed...
> It is a bit noisy to have this extra file in the BIN_SH_NONE case, and
> it afaik changes behaviour (E.G. getusershell() will return default
> values if there is no /etc/shells, but will now presumably return the
> empty string).
Woah.. I did not know about getusershell(), but its API is ugly... :-/
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-01-15 17:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 21:03 [Buildroot] [PATCH 0/7] Add /etc/shells handling Romain Naour
2018-01-14 21:03 ` [Buildroot] [PATCH 1/7] package/skeleton-init-common: add /bin/sh to /etc/shells Romain Naour
2018-01-14 22:51 ` Yann E. MORIN
2018-01-15 14:41 ` Peter Korsgaard
2018-01-15 17:06 ` Yann E. MORIN [this message]
2018-01-14 21:03 ` [Buildroot] [PATCH 2/7] package/busybox: add /bin/ash " Romain Naour
2018-01-14 22:43 ` Yann E. MORIN
2018-01-17 15:17 ` Romain Naour
2018-01-14 21:03 ` [Buildroot] [PATCH 3/7] package/dash: add /etc/dash " Romain Naour
2018-01-14 22:26 ` Yann E. MORIN
2018-01-14 21:03 ` [Buildroot] [PATCH 4/7] package/screen: add /usr/bin/screen " Romain Naour
2018-01-14 22:29 ` Yann E. MORIN
2018-01-14 22:36 ` Yann E. MORIN
2018-01-14 21:03 ` [Buildroot] [PATCH 5/7] package/tmux: add /usr/bin/tmux " Romain Naour
2018-01-14 22:30 ` Yann E. MORIN
2018-01-14 21:03 ` [Buildroot] [PATCH 6/7] package/zsh: add /bin/zsh " Romain Naour
2018-01-14 22:34 ` Yann E. MORIN
2018-01-14 21:03 ` [Buildroot] [PATCH 7/7] package/mksh: add /bin/mksh " Romain Naour
2018-01-14 22:37 ` Yann E. MORIN
2018-01-15 10:35 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115170644.GB11122@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox