From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 15 Jan 2018 21:20:25 +0100 Subject: [Buildroot] [PATCH 1/1] libpqxx: apply upstream compilation fix In-Reply-To: <20180115200055.6404-1-james.knight@rockwellcollins.com> References: <20180115200055.6404-1-james.knight@rockwellcollins.com> Message-ID: <20180115212025.482dad6f@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Mon, 15 Jan 2018 15:00:55 -0500, James Knight wrote: > Apply an upstream patch which addresses a compilation issue with respect > to an undefined 'timeval' structure. This issue exists in at least v6.0. > It is expected that this patch can be removed when libpqxx provides a > new releases (either v6.0.1 or v6.1). > > Fixes: > http://autobuild.buildroot.net/results/48b015650ede4e55e199538072c7228cccf64422 > > Signed-off-by: James Knight > --- > package/libpqxx/libpqxx.hash | 1 + > package/libpqxx/libpqxx.mk | 7 +++++++ > 2 files changed, 8 insertions(+) > > diff --git a/package/libpqxx/libpqxx.hash b/package/libpqxx/libpqxx.hash > index 372be603c5..6fc388fc89 100644 > --- a/package/libpqxx/libpqxx.hash > +++ b/package/libpqxx/libpqxx.hash > @@ -1,3 +1,4 @@ > # Locally computed: > sha256 81cac92458efd799fadb0374107464320d93eba71de05aedf21afb9c8dda7c3a libpqxx-6.0.0.tar.gz > sha256 9e1c78fa302e4e9738bf3315b130429035c03fcb0f046531ccd977cb474f6b31 COPYING > +sha256 85881a11caab61f0c8d10cfef673e48c86e701f5a9fdd6cb344aa4f4beb1f2bf 44970d7331e4f369e160af0135a2d1fc16f27a21.patch Thanks, but please add the patch itself in package/libpqxx/. We stopped fetching patches from github this way, because those patches are not stable, and therefore their hash might change. Indeed, the line "index ccafa9ce71..23b0953735 100644" contains references to Git commits, but those references are partial (i.e not the full 40 digits SHA1). Due to this, when more commits are made to the same repos, git may add additional digits in this "index" line to ensure the commit references and non-ambiguous. Good for Git, but bad for the patch hash. Hence, please bring the patch inside package/libpqxx/. Thanks! :-) Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com