From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/8] package/skeleton-init-common: add /bin/sh to /etc/shells
Date: Wed, 17 Jan 2018 19:44:53 +0100 [thread overview]
Message-ID: <20180117184453.GB11009@scaer> (raw)
In-Reply-To: <1516211058-466-2-git-send-email-romain.naour@smile.fr>
Romain, All,
On 2018-01-17 18:44 +0100, Romain Naour spake thusly:
> Add the default shell /bin/sh to /etc/shells only if BR2_SYSTEM_BIN_SH_NONE
> is not selected.
>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> v2: add double-dollar after /bin/sh (Yann)
> remove empty /etc/shells from skeleton (Yann, Peter)
> move the hook right after it's defined (Yann)
> ---
> package/skeleton-init-common/skeleton-init-common.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/skeleton-init-common/skeleton-init-common.mk b/package/skeleton-init-common/skeleton-init-common.mk
> index 8228a81..03cb744 100644
> --- a/package/skeleton-init-common/skeleton-init-common.mk
> +++ b/package/skeleton-init-common/skeleton-init-common.mk
> @@ -79,6 +79,13 @@ define SKELETON_INIT_COMMON_SET_BIN_SH
> rm -f $(TARGET_DIR)/bin/sh
> endef
> else
> +# Add /bin/sh to /etc/shells otherwise some login tools like dropbear
> +# can reject the user connexion. See man shells.
> +define SKELETON_INIT_COMMON_ADD_SH_TO_SHELLS
> + grep -qsE '^/bin/sh$$' $(TARGET_DIR)/etc/shells \
> + || echo "/bin/sh" >> $(TARGET_DIR)/etc/shells
> +endef
> +SKELETON_INIT_COMMON_POST_INSTALL_TARGET_HOOKS += SKELETON_INIT_COMMON_ADD_SH_TO_SHELLS
> ifneq ($(SKELETON_INIT_COMMON_BIN_SH),)
> define SKELETON_INIT_COMMON_SET_BIN_SH
> ln -sf $(SKELETON_INIT_COMMON_BIN_SH) $(TARGET_DIR)/bin/sh
> --
> 2.7.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-01-17 18:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 17:44 [Buildroot] [PATCH v2 0/8] Add /etc/shells handling Romain Naour
2018-01-17 17:44 ` [Buildroot] [PATCH v2 1/8] package/skeleton-init-common: add /bin/sh to /etc/shells Romain Naour
2018-01-17 18:44 ` Yann E. MORIN [this message]
2018-01-17 17:44 ` [Buildroot] [PATCH v2 2/8] package/busybox: add /bin/{a, hu}sh " Romain Naour
2018-01-17 18:48 ` Yann E. MORIN
2018-01-17 17:44 ` [Buildroot] [PATCH v2 3/8] package/dash: add /etc/dash " Romain Naour
2018-01-17 19:19 ` Yann E. MORIN
2018-01-17 17:44 ` [Buildroot] [PATCH v2 4/8] package/screen: add /usr/bin/screen " Romain Naour
2018-01-17 19:25 ` Yann E. MORIN
2018-01-17 17:44 ` [Buildroot] [PATCH v2 5/8] package/tmux: add /usr/bin/tmux " Romain Naour
2018-01-17 19:25 ` Yann E. MORIN
2018-01-17 17:44 ` [Buildroot] [PATCH v2 6/8] package/zsh: add /bin/zsh " Romain Naour
2018-01-17 19:26 ` Yann E. MORIN
2018-01-17 17:44 ` [Buildroot] [PATCH v2 7/8] package/mksh: add /bin/mksh " Romain Naour
2018-01-17 19:29 ` Yann E. MORIN
2018-01-17 17:44 ` [Buildroot] [PATCH v2 8/8] package/bash: add missing double-dollar for /etc/shells Romain Naour
2018-01-17 19:30 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117184453.GB11009@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox