From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 27 Jan 2018 23:07:07 +0100 Subject: [Buildroot] [PATCH 2/2] ltp-testsuite: drop redundant arch dependency entries In-Reply-To: <2f61c63d53f8ba4ea0b65942b57f67a156fbf778.1516964598.git.baruch@tkos.co.il> References: <944db376505dab7095cf32949160c0d024d92926.1516964598.git.baruch@tkos.co.il> <2f61c63d53f8ba4ea0b65942b57f67a156fbf778.1516964598.git.baruch@tkos.co.il> Message-ID: <20180127230707.450300b0@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Fri, 26 Jan 2018 13:03:18 +0200, Baruch Siach wrote: > BR2_TOOLCHAIN_HAS_SYNC_4 is enabled for all these architectures except > arc. There is no need to list them explicitly. > > Cc: Romain Naour > Cc: Petr Vorel > Signed-off-by: Baruch Siach > --- > package/ltp-testsuite/Config.in | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/package/ltp-testsuite/Config.in b/package/ltp-testsuite/Config.in > index 4c00e40f330e..711c859e6caf 100644 > --- a/package/ltp-testsuite/Config.in > +++ b/package/ltp-testsuite/Config.in > @@ -5,11 +5,6 @@ config BR2_PACKAGE_LTP_TESTSUITE_ARCH_SUPPORTS > # provided in ltp-testsuite > default y if BR2_TOOLCHAIN_HAS_SYNC_4 > default y if BR2_arc > - default y if BR2_i386 > - default y if BR2_powerpc > - default y if BR2_powepc64 > - default y if BR2_powerpc64le > - default y if BR2_x86_64 Is this really a correct patch ? It's not because BR2_TOOLCHAIN_HAS_SYNC_4 already covers i386/powerpc/powerpc64/powerpc64le/x86_64 that it makes sense to use BR2_TOOLCHAIN_HAS_SYNC_4 instead. What if an architecture gets added to BR2_TOOLCHAIN_HAS_SYNC_4, but isn't supported by ltp-testsuite ? Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com