From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC] scanpypi: handle packages with wrong metadata
Date: Mon, 29 Jan 2018 23:19:08 +0100 [thread overview]
Message-ID: <20180129231908.4bf07275@windsurf.lan> (raw)
In-Reply-To: <1516973570-7732-1-git-send-email-yegorslists@googlemail.com>
Hello,
On Fri, 26 Jan 2018 14:32:50 +0100, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> Some packages like python-adafruit-ads1x15 have different values in
> PyPI metadata and setup.py or tar file name.
>
> Use package name (self.pkg_name) derived from tar file name instead
> of metadata_name taken from JSON.
>
> Also output the missing key when trying to setup arguments.
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Do we really want to do this? Shouldn't we instead ask the upstream
maintainers to fix their Python package? I have the feeling that this
is a slippery road, and we could start adding lots and lots of weird
logic to support packages with wrong metadata.
If it's only fixing one specific package, I'd say the script should
instead detect the inconsistency, and bail out.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2018-01-29 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 13:32 [Buildroot] [RFC] scanpypi: handle packages with wrong metadata yegorslists at googlemail.com
2018-01-29 22:19 ` Thomas Petazzoni [this message]
2018-01-30 7:43 ` Yegor Yefremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129231908.4bf07275@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox