From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ltp-testsuite: Add upstream patch to fix build numa detection
Date: Fri, 2 Feb 2018 14:59:57 +0100 [thread overview]
Message-ID: <20180202135956.GB8864@x230> (raw)
In-Reply-To: <20180202052328.f66l4zb2n6zkoypl@tarshish>
Hi Baruch,
thanks for your explanation!
> numactl is also an optional build time dependency of ltp-testsuite. When the
> ltp-testsuite configure script detects libnuma some additional tests are
> built.
I was thinking some time ago to add this support, but it's not how it works.
All sources which depends on NUMA have a preprocessor condition like his: [1]
#ifdef HAVE_NUMA_V2
...
#else
TST_TEST_TCONF("test requires libnuma >= 2 and it's development packages");
#endif
(These are using new LTP test API, tests using old API or not using API at all have it
implemented differently.)
I added HAVE_NUMA_V2 in commit bf3441268 ("numa: Check for API >= v2 with autoconf"), but
it the check has always been like that (*) all the tests are actually being build
regardless of NUMA support on SUT. I mean, there is no rule in Makefile which would
prevent build them because missing NUMA. This is unusual, but the reason why tests are
build just to say "you need libnuma support", that these files are expected in runtest
files (files in $LTPROOT/runtest).
(*) This approach was added in the sources in 2010.
> Currently when the numactl package is enabled, ltp-testsuite would
> detect libnuma only if numactl happens to build before ltp-testsuite. To make
> builds consistent we need to make sure that numactl always build before
> ltp-testsuite by adding it to _DEPENDENCIES. Here is how the hwloc package
> does that:
> ifeq ($(BR2_PACKAGE_NUMACTL),y)
> HWLOC_CONF_OPTS += --enable-libnuma
> HWLOC_DEPENDENCIES += numactl
> else
> HWLOC_CONF_OPTS += --disable-libnuma
> endif
So this is not needed.
> ltp-testsuite needs something similar.
> baruch
Kind regards,
Petr
[1] https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/mem/cpuset/cpuset01.c
next prev parent reply other threads:[~2018-02-02 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 20:23 [Buildroot] [PATCH 1/1] ltp-testsuite: Add upstream patch to fix build numa detection Petr Vorel
2018-01-29 22:16 ` Thomas Petazzoni
2018-01-30 5:15 ` Baruch Siach
2018-02-01 22:19 ` Petr Vorel
2018-02-02 5:23 ` Baruch Siach
2018-02-02 13:59 ` Petr Vorel [this message]
2018-02-03 19:27 ` Baruch Siach
2018-02-07 18:05 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202135956.GB8864@x230 \
--to=petr.vorel@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox