Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5] package/x11r7/xlib_libxshmfence: fix build with glibc 2.27
Date: Mon, 5 Feb 2018 22:08:12 +0100	[thread overview]
Message-ID: <20180205210812.GA2806@scaer> (raw)
In-Reply-To: <20180205205716.4279-1-romain.naour@gmail.com>

Romain, All,

On 2018-02-05 21:57 +0100, Romain Naour spake thusly:
> With glibc 2.27 memfd_create() is inside a _GNU_SOURCE guard, so call
> AC_USE_SYSTEM_EXTENSIONS to get this defined.
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  ...onfigure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch | 30 ++++++++++++++++++++++
>  .../x11r7/xlib_libxshmfence/xlib_libxshmfence.mk   |  3 +++
>  2 files changed, 33 insertions(+)
>  create mode 100644 package/x11r7/xlib_libxshmfence/0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch
> 
> diff --git a/package/x11r7/xlib_libxshmfence/0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch b/package/x11r7/xlib_libxshmfence/0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch
> new file mode 100644
> index 0000000000..f24b1da5dd
> --- /dev/null
> +++ b/package/x11r7/xlib_libxshmfence/0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch
> @@ -0,0 +1,30 @@
> +From 0b550a4e7acf02d3478602848f6afbfcbfb0d4b2 Mon Sep 17 00:00:00 2001
> +From: Ross Burton <ross.burton@intel.com>
> +Date: Mon, 29 Jan 2018 16:24:36 +0000
> +Subject: [PATCH] configure.ac: call AC_USE_SYSTEM_EXTENSIONS
> +
> +With glibc 2.27 memfd_create() is inside a _GNU_SOURCE guard, so call
> +AC_USE_SYSTEM_EXTENSIONS to get this defined.
> +
> +Signed-off-by: Ross Burton <ross.burton@intel.com>
> +Signed-off-by: Romain Naour <romain.naour@gmail.com>

This looks liek it is a backport from upstream, right? If so, please say
so; in such a case I like to add something like:

    [yann: backport from upstream URL-or-commit]
    Signed-off-by: ME

Regards,
Yann E. MORIN.

> +---
> + configure.ac | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/configure.ac b/configure.ac
> +index 55772d0..ed77e6d 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -28,6 +28,8 @@ AC_INIT([libxshmfence], [1.2],
> + AC_CONFIG_SRCDIR([Makefile.am])
> + AC_CONFIG_HEADERS([config.h])
> + 
> ++AC_USE_SYSTEM_EXTENSIONS
> ++
> + # Initialize Automake
> + AM_INIT_AUTOMAKE([foreign dist-bzip2])
> + 
> +-- 
> +2.14.3
> +
> diff --git a/package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk b/package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk
> index 3a2f32623a..9686c408c1 100644
> --- a/package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk
> +++ b/package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk
> @@ -12,4 +12,7 @@ XLIB_LIBXSHMFENCE_LICENSE_FILES = COPYING
>  XLIB_LIBXSHMFENCE_INSTALL_STAGING = YES
>  XLIB_LIBXSHMFENCE_DEPENDENCIES = host-pkgconf xproto_xproto
>  
> +# 0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch
> +XLIB_LIBXSHMFENCE_AUTORECONF = YES
> +
>  $(eval $(autotools-package))
> -- 
> 2.14.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2018-02-05 21:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 20:57 [Buildroot] [PATCH 1/5] package/x11r7/xlib_libxshmfence: fix build with glibc 2.27 Romain Naour
2018-02-05 20:57 ` [Buildroot] [PATCH 2/5] package/pulseaudio: only define memfd_create() if not already defined Romain Naour
2018-02-05 20:57 ` [Buildroot] [PATCH 3/5] package/libraw: rename internal powf64 Romain Naour
2018-02-05 20:57 ` [Buildroot] [PATCH 4/5] package/glibc: remove GLIBC_SRC_SUBDIR Romain Naour
2018-02-05 21:27   ` Yann E. MORIN
2018-02-05 20:57 ` [Buildroot] [PATCH 5/5] package/glibc: bump to 2.27 Romain Naour
2018-02-05 21:01   ` Baruch Siach
2018-02-05 21:16     ` Romain Naour
2018-02-05 21:41     ` Yann E. MORIN
2018-02-05 23:32       ` Peter Korsgaard
2018-02-06  4:15       ` Baruch Siach
2018-02-06  8:18     ` Arnout Vandecappelle
2018-02-06 10:50       ` Baruch Siach
2018-02-06 12:38         ` Arnout Vandecappelle
2018-02-06 13:44         ` Peter Korsgaard
2018-02-06 13:46           ` Baruch Siach
2018-02-06 14:41             ` Peter Korsgaard
2018-02-06 16:40               ` Baruch Siach
2018-02-05 21:08 ` Yann E. MORIN [this message]
2018-02-06 12:43 ` [Buildroot] [PATCH 1/5] package/x11r7/xlib_libxshmfence: fix build with glibc 2.27 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180205210812.GA2806@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox