From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/4] linux: add custom linux logo
Date: Tue, 6 Feb 2018 15:51:37 +0100 [thread overview]
Message-ID: <20180206155137.0b462c6c@windsurf> (raw)
In-Reply-To: <1505819034-29610-3-git-send-email-angelo.compagnucci@gmail.com>
Hello,
On Tue, 19 Sep 2017 13:03:52 +0200, Angelo Compagnucci wrote:
> +config BR2_LINUX_KERNEL_CUSTOMLOGO
> + bool "Kernel custom logo"
> + select BR2_PACKAGE_CUSTOMLOGO
> + help
> + Change the linux boot logo with your own graphics.
> + It can be used as an early bootsplash.
> + The file should be in kernel ppm format if the
> + option BR2_LINUX_KERNEL_CUSTOMLOGO_CONVERT is not
> + selected.
> +
> +config BR2_LINUX_KERNEL_CUSTOMLOGO_PATH
> + string "Image file path"
> + depends on BR2_LINUX_KERNEL_CUSTOMLOGO
> + help
> + This image will be used as custom logo.
> +
> +config BR2_LINUX_KERNEL_CUSTOMLOGO_CONVERT
> + bool "Convert custom logo to kernel format"
> + depends on BR2_LINUX_KERNEL_CUSTOMLOGO
> + help
> + If checked, the convert command will be run on the source
> + image file to obtain a kernel compatible ppm image file.
There are too many options here. We would like to have just one option:
BR2_LINUX_KERNEL_CUSTOMLOGO_PATH. If empty, nothing happens, if
non-empty, stuff happens.
Just do the "convert" call unconditionally, so we don't need the
BR2_LINUX_KERNEL_CUSTOMLOGO_CONVERT option.
Also, use CUSTOM_LOGO instead of CUSTOMLOGO.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-02-06 14:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 11:03 [Buildroot] [PATCH 0/4] Add custom linux logo Angelo Compagnucci
2017-09-19 11:03 ` [Buildroot] [PATCH 1/4] package/imagemagick: add host package Angelo Compagnucci
2017-09-19 11:03 ` [Buildroot] [PATCH 2/4] linux: add custom linux logo Angelo Compagnucci
2018-02-06 14:51 ` Thomas Petazzoni [this message]
2018-02-06 14:53 ` Thomas Petazzoni
2017-09-19 11:03 ` [Buildroot] [PATCH 3/4] docs/images: adding default buildroot " Angelo Compagnucci
2018-02-06 14:52 ` Thomas Petazzoni
2017-09-19 11:03 ` [Buildroot] [PATCH 4/4] configs: add linux boot logo to raspberrypi3 defconfig Angelo Compagnucci
2018-02-06 14:49 ` Bryce Ferguson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206155137.0b462c6c@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox