From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ltp-testsuite: add numactl as optional dependency
Date: Wed, 7 Feb 2018 20:49:08 +0100 [thread overview]
Message-ID: <20180207194907.GA1349@x230> (raw)
In-Reply-To: <cd25369f9e0588a17965bbabcf6214c110f86ef4.1518030288.git.baruch@tkos.co.il>
Hi Baruch,
> Make the detection of libnuma in the configure script consistent when
> the numactl package is enabled.
> ltp-testsuite does not currently take explicit enable/disable for
> libnuma, so none are used. The next ltp-testsuite version will add these
> options.
> Cc: Petr Vorel <petr.vorel@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/ltp-testsuite/ltp-testsuite.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
> diff --git a/package/ltp-testsuite/ltp-testsuite.mk b/package/ltp-testsuite/ltp-testsuite.mk
> index 5e0b35d12a22..c47f587836b3 100644
> --- a/package/ltp-testsuite/ltp-testsuite.mk
> +++ b/package/ltp-testsuite/ltp-testsuite.mk
> @@ -40,6 +40,13 @@ else
> LTP_TESTSUITE_CONF_ENV += ac_cv_lib_cap_cap_compare=no
> endif
> +# No explicit enable/disable options
> +ifeq ($(BR2_PACKAGE_NUMACTL),y)
> +LTP_TESTSUITE_DEPENDENCIES += numactl
> +else
> +LTP_TESTSUITE_CONF_ENV += have_numa_headers=no
> +endif
> +
> # ltp-testsuite uses <fts.h>, which isn't compatible with largefile
> # support.
> LTP_TESTSUITE_CFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
Thanks for implementing it, LGTM.
I just think whether it wouldn't be better to create config option
BR2_PACKAGE_LTP_TESTSUITE_LIBNUMA which would select numactl (this would also inform user
about this dependency).
Kind regards,
Petr
next prev parent reply other threads:[~2018-02-07 19:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 19:04 [Buildroot] [PATCH] ltp-testsuite: add numactl as optional dependency Baruch Siach
2018-02-07 19:49 ` Petr Vorel [this message]
2018-02-08 0:29 ` Arnout Vandecappelle
2018-02-08 8:56 ` Petr Vorel
2018-02-08 22:12 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207194907.GA1349@x230 \
--to=petr.vorel@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox