Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [RFCv2 1/3] qemu: add BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS
Date: Wed, 7 Feb 2018 22:39:47 +0100	[thread overview]
Message-ID: <20180207213947.GA2007@scaer> (raw)
In-Reply-To: <20180207212355.7464-2-aduskett@gmail.com>

Adam, All,

On 2018-02-07 16:23 -0500, Adam Duskett spake thusly:
> Match the style used with other packages such as valgrind.
> 
> Signed-off-by: Adam Duskett <aduskett@gmail.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

However, small comment below...

> ---
>  package/qemu/Config.in.host | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/package/qemu/Config.in.host b/package/qemu/Config.in.host
> index 71f38ef41f..78fe54a85c 100644
> --- a/package/qemu/Config.in.host
> +++ b/package/qemu/Config.in.host
> @@ -1,15 +1,20 @@
> -config BR2_PACKAGE_HOST_QEMU
> -	bool "host qemu"
> -	depends on BR2_arm       || BR2_armeb       || BR2_aarch64      || \
> +config BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS
> +	bool
> +	default y if BR2_arm || BR2_armeb       || BR2_aarch64      || \
>  		BR2_i386         || BR2_m68k        || BR2_microblazeel || \
>  		BR2_microblazebe || BR2_mips        || BR2_mipsel       || \
>  		BR2_mips64       || BR2_mips64el    || BR2_powerpc      || \
>  		BR2_powerpc64    || BR2_powerpc64le || BR2_sh           || \
>  		BR2_sparc        || BR2_x86_64

This would become more readable if we were to write:

    default y if BR2_arm || BR2_armeb
    default y if BR2_aarch64
    default y if BR2_i386 || BR2_x86_64
    etc...

But of course, not part of this patch. ;-)

> +config BR2_PACKAGE_HOST_QEMU
> +	bool "host qemu"
> +	depends on BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS
>  	select BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE \
>  		if !BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE
>  	help
> -	  QEMU is a generic and open source machine emulator and virtualizer.
> +	  QEMU is a generic and open source machine emulator and
> +	  virtualizer.

Spurious wrapping. Not very important...

Regards,
Yann E. MORIN.

>  	  This option builds an emulator for your selected architecture.
>  
> -- 
> 2.14.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2018-02-07 21:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07 21:23 [Buildroot] [RFCv2 0/1] gobject-introspection: new series Adam Duskett
2018-02-07 21:23 ` [Buildroot] [RFCv2 1/3] qemu: add BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS Adam Duskett
2018-02-07 21:39   ` Yann E. MORIN [this message]
2018-02-08 21:19   ` Thomas Petazzoni
2018-02-07 21:23 ` [Buildroot] [RFCv2 2/3] gobject-introspection: new package Adam Duskett
2018-02-08  4:43   ` Baruch Siach
2018-02-08 13:54     ` Adam Duskett
2018-02-08 13:58       ` Adam Duskett
2018-02-08 16:40         ` Baruch Siach
2018-02-08 16:48           ` Adam Duskett
2018-02-07 21:23 ` [Buildroot] [RFCv2 3/3] gstreamer1: support gobject-introspection Adam Duskett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180207213947.GA2007@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox