From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] busybox: bump to 1.28.0
Date: Thu, 8 Feb 2018 23:14:52 +0100 [thread overview]
Message-ID: <20180208231452.0c2691db@windsurf.lan> (raw)
In-Reply-To: <20180207145215.19465-1-aduskett@gmail.com>
Hello,
On Wed, 7 Feb 2018 09:52:15 -0500, Adam Duskett wrote:
> diff --git a/package/busybox/0002-Makefile.flags-strip-non-l-arguments-returned-by-pkg.patch b/package/busybox/0002-Makefile.flags-strip-non-l-arguments-returned-by-pkg.patch
> index 105626cbe2..4a9881a075 100644
> --- a/package/busybox/0002-Makefile.flags-strip-non-l-arguments-returned-by-pkg.patch
> +++ b/package/busybox/0002-Makefile.flags-strip-non-l-arguments-returned-by-pkg.patch
> @@ -4,6 +4,8 @@ Date: Mon, 25 Nov 2013 22:51:53 +0100
> Subject: [PATCH] Makefile.flags: strip non -l arguments returned by pkg-config
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> +[Adam Duskett: update for busybox 1.28.0]
> +Signed-off-by: Adam Duskett <aduskett@gmail.com>
Can I ask that you refrain from adding such lines when the patch is
simply refreshed? If you're doing some real changes in the patch to fix
some conflicts, then it's fine to add that. But you seem to be adding
these lines whenever a patch is preserved, even if it has just been
refreshed in terms of line offsets. To me, re-adding a comment + SoB in
such a situation is useless noise.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-02-08 22:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 14:52 [Buildroot] [PATCH 1/1] busybox: bump to 1.28.0 Adam Duskett
2018-02-07 14:59 ` Baruch Siach
2018-02-07 15:30 ` Adam Duskett
2018-02-07 18:26 ` Baruch Siach
2018-02-07 23:45 ` Arnout Vandecappelle
2018-02-08 22:14 ` Thomas Petazzoni [this message]
2018-02-08 22:22 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208231452.0c2691db@windsurf.lan \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox