From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] musl: add more kernel headers guards
Date: Tue, 13 Feb 2018 14:47:13 +0200 [thread overview]
Message-ID: <20180213124713.hrfr3bh3eigputkr@tarshish> (raw)
In-Reply-To: <20180213133230.3a99ae2c@windsurf.lan>
Hi Thomas,
On Tue, Feb 13, 2018 at 01:32:30PM +0100, Thomas Petazzoni wrote:
> On Tue, 13 Feb 2018 14:27:49 +0200, Baruch Siach wrote:
> > Kernel version 4.15 (not 4.16 as the musl commit log claims) allows
> > disabling of more parts of the kernel headers definitions. Add upstream
> > musl patch that defines the relevant macros. This solves issues of
> > networking related symbols redefinition in kernel headers that cause
> > headers conflicts. With that in place a subsequent commit will limit the
> > musl/kernel headers conflict avoidance workaround in Buildroot to kernel
> > headers older than 4.15. This workaround has been introduced in commit
> > 196932cd91 (toolchain: workaround musl/kernel headers conflict).
> >
> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> Thanks for those patches, it's great to see that you continue to
> follow this header conflict issue. You didn't specify explicitly if you
> intend them for master or next. At this point, I don't see a reason to
> need them for master, so it's probably material for next. Do you agree ?
Of course. Sorry. I didn't say that explicitly because I thought it obviously
belongs to next. These patches would better see lots of autobuilders testing.
Until the musl toolchains get rebuilt, only internal musl toolchain builds
will actually test this code.
By the way, you should probably update the email address in your DEVELOPERS
entry.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2018-02-13 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 12:27 [Buildroot] [PATCH 1/2] musl: add more kernel headers guards Baruch Siach
2018-02-13 12:27 ` [Buildroot] [PATCH 2/2] toolchain: limit musl/kernel headers conflict workaround Baruch Siach
2018-03-30 19:19 ` Peter Korsgaard
2018-02-13 12:32 ` [Buildroot] [PATCH 1/2] musl: add more kernel headers guards Thomas Petazzoni
2018-02-13 12:47 ` Baruch Siach [this message]
2018-02-14 21:02 ` Thomas Petazzoni
2018-03-30 19:19 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213124713.hrfr3bh3eigputkr@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox