Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/testing: fix job check-gitlab-ci.yml
Date: Tue, 13 Feb 2018 23:12:10 +0100	[thread overview]
Message-ID: <20180213231210.185efcfb@windsurf.lan> (raw)
In-Reply-To: <1518469328-5895-1-git-send-email-ricardo.martincoski@gmail.com>

Hello,

On Mon, 12 Feb 2018 19:02:08 -0200, Ricardo Martincoski wrote:
> Currently 'run-tests -l' is broken. It breaks 'make .gitlab-ci.yml' that
> in turn breaks the job in GitLab.
> 
> TestRustBase is not a test case by itself, so it can't have a method
> with the name starting with "test_" otherwise nose2 assumes it is a test
> case.
> Move the test_run method from the base class to the derived classes.
> 
> While at it, update .gitlab-ci.yml with the new test cases.
> 
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/52000035
> 
> Reported-by: Yegor Yefremov <yegorslists@googlemail.com>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> check-gitlab-ci.yml after the fix:
> https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/52092002
> which is part of a full run:
> https://gitlab.com/RicardoMartincoski/buildroot/pipelines/17391318
> ---
>  .gitlab-ci.yml                             |  2 ++
>  support/testing/tests/package/test_rust.py | 18 ++++++++++++------
>  2 files changed, 14 insertions(+), 6 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2018-02-13 22:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09  8:44 [Buildroot] [next] listing of tests is broken Yegor Yefremov
2018-02-09  8:54 ` Thomas Petazzoni
2018-02-09  9:04   ` Yegor Yefremov
2018-02-09 10:06     ` Thomas Petazzoni
2018-02-12  1:44       ` Ricardo Martincoski
2018-02-12  8:07         ` Thomas Petazzoni
2018-02-12 21:02           ` [Buildroot] [PATCH] support/testing: fix job check-gitlab-ci.yml Ricardo Martincoski
2018-02-13  5:02             ` Yegor Yefremov
2018-02-13 22:12             ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180213231210.185efcfb@windsurf.lan \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox