From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] cmake: bump version to 3.10.2 and add license hash
Date: Wed, 14 Feb 2018 16:04:18 +0100 [thread overview]
Message-ID: <20180214160418.2cf49d57@windsurf.lan> (raw)
In-Reply-To: <6AE94196-F3D3-4887-BC12-EDBA8A3A4AA3@gmail.com>
Hello,
On Wed, 14 Feb 2018 06:48:36 -0800, Mark Hirota wrote:
> Thank you for providing that patchwork link, as it provides excellent
> background on this. It seems that the build failures you?re
> referring to can only be seen once a change occurs on master?
No, you can reproduce the issue if you build host-cmake in an old
enough system, such as a system that has a host gcc < 4.8.
> Perhaps I should submit a patch for cmake 3.9.6 instead? This is
> because my goal is to have support for LTO the or
> CMAKE_INTERPROCEDURAL_OPTIMIZATION variable.
I'm not familiar with CMake numbering scheme. Isn't 3.8.x and 3.10.x
stable, and 3.9.x development ?
I think the most appropriate approach is instead to make the
->emplace_hint() method call conditional. It is only there to "hint" at
where some element should be placed in a list, and looks like an
optimization. Perhaps it could fallback on something else if
->emplace_hint() is not available.
Alternatively, this ->emplace_hint() is only used in the Ninja backend,
so if the Ninja backend could be conditionally enabled/disabled, it
would allow to disable it when the host gcc is too old.
It's just that IMO it's too early for Buildroot to drop support for
build machines that don't have at least gcc 4.8.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
prev parent reply other threads:[~2018-02-14 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 19:57 [Buildroot] [PATCH 1/1] cmake: bump version to 3.10.2 and add license hash Mark Hirota
2018-02-13 22:25 ` Thomas Petazzoni
2018-02-14 14:48 ` Mark Hirota
2018-02-14 15:04 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214160418.2cf49d57@windsurf.lan \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox