From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Sets LD_LIBRARY_PATH inside toolchain-wrapper.
Date: Sun, 18 Feb 2018 15:30:12 +0100 [thread overview]
Message-ID: <20180218153012.58e0b0e1@windsurf> (raw)
In-Reply-To: <CANepG=PL=4t10iC=GUi2F5BkEUH27XyCpMAFfk2g3hDQwESgcw@mail.gmail.com>
Hello,
On Fri, 16 Feb 2018 21:43:36 -0300, Daniel Serpell wrote:
> I see that you are using patchelf to make RPATH relative inside host binaries,
> is there any reason to not run that always, or at least in the "make toolchain"
> target?
Because there's no real reason to do that. During the build, the
toolchain and other host tools are not moving, so keeping the absolute
RPATH is fine. It's only when you want to move the toolchain/SDK around
that the rpath needs to be adjusted to be relative RPATH.
> I'm not very good at writing documentation, perhaps the attached patch
> is enough.
Patch looks good. Could you send it with "git send-email", and change
the commit title to something like:
docs/manual: add documentation for the "make sdk" target
Thanks!
Thoas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
prev parent reply other threads:[~2018-02-18 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 22:18 [Buildroot] [PATCH] Sets LD_LIBRARY_PATH inside toolchain-wrapper Daniel Serpell
2018-02-16 22:46 ` Thomas Petazzoni
[not found] ` <CANepG=MckvkieMHtLfR2fsrH1yJzvjUwDiritOk-YvP5-ghE8g@mail.gmail.com>
2018-02-17 0:43 ` Daniel Serpell
2018-02-18 14:30 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180218153012.58e0b0e1@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox