From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 19 Feb 2018 09:02:54 +0100 Subject: [Buildroot] [PATCH 1/3] imx-mkimage: new package In-Reply-To: References: <1518960511-4823-1-git-send-email-karl.erik.larsson@gmail.com> <1518960511-4823-2-git-send-email-karl.erik.larsson@gmail.com> <20180218155100.3e4e090f@windsurf> Message-ID: <20180219090254.05ce8a8f@windsurf.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Erik, On Mon, 19 Feb 2018 06:43:15 +0100, Erik Larsson wrote: > > > diff --git a/package/freescale-imx/imx-mkimage/0001-make-bl33-read-env-variables.patch > > b/package/freescale-imx/imx-mkimage/0001-make-bl33-read- > > env-variables.patch > > > new file mode 100644 > > > index 0000000..490eb05 > > > --- /dev/null > > > +++ b/package/freescale-imx/imx-mkimage/0001-make-bl33-read- > > env-variables.patch > > > @@ -0,0 +1,37 @@ > > > +From 5ca549356ef889286c12b4d736d9026efafb8fff Mon Sep 17 00:00:00 2001 > > > +From: Erik Larsson > > > +Date: Mon, 29 Jan 2018 08:00:57 +0100 > > > +Subject: [PATCH] Add support for overriding BL32 and BL33 not only BL31 > > > + > > > +Signed-off-by: Erik Larsson > > > +Signed-off-by: Christopher Dahlberg > > > +Signed-off-by: Marcus Folkesson > > > > What is the upstream status of this patch ? > > > I've sent the patch to some of the developers, but still waiting for a > reaction. OK. Then who are those other people who have Signed-off on your patch ? > > Why are you building just the tool in iMX8M ? There is also one in src/ > > and in iMX8dv. What are the differences ? Should we build/install all > > of them ? Conditionally ? > > > I'm currently only building for IMX8M because that's the only hardware I > have access to. Preferably this should be conditional. Do you think I shall > add it as a conditional option right away event though I can't test it > against other hardware? It's fine to support just what you need today. However, it would be nice to explain it in the commit log and/or in a comment above those lines in the .mk file. Thanks a lot! Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com