From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] package/llvm: new host package
Date: Mon, 19 Feb 2018 21:22:13 +0100 [thread overview]
Message-ID: <20180219212213.33f289c4@windsurf.home> (raw)
In-Reply-To: <20180219171805.13769-2-valentin.korenblit@smile.fr>
Hello,
I have by far not reviewed everything, but noticed one problem.
On Mon, 19 Feb 2018 18:18:03 +0100, Valentin Korenblit wrote:
> +# Get target architecture
> +HOST_LLVM_TARGET_ARCH = $(call qstrip,$(BR2_PACKAGE_LLVM_TARGET_ARCH))
BR2_PACKAGE_LLVM_TARGET_ARCH does not exist, it is created by PATCH
2/3. This is not good, as it breaks bisectability.
Basically, your series should work even if we apply only PATCH 1/3. Or
if we apply only PATCH 1/3 and 2/3, etc.
So using in PATCH 1/3 something that is introduced in PATCH 2/3 is not
good.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-02-19 20:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 17:18 [Buildroot] [PATCH v2 0/3] llvm for mesa3d Valentin Korenblit
2018-02-19 17:18 ` [Buildroot] [PATCH v2 1/3] package/llvm: new host package Valentin Korenblit
2018-02-19 20:22 ` Thomas Petazzoni [this message]
2018-02-20 10:15 ` Valentin Korenblit
2018-02-20 12:13 ` Nimai Mahajan
2018-02-20 12:41 ` Thomas Petazzoni
2018-02-20 17:41 ` Nimai Mahajan
2018-02-20 17:51 ` Adrian Perez de Castro
2018-02-19 17:18 ` [Buildroot] [PATCH v2 2/3] package/llvm: enable target variant Valentin Korenblit
2018-02-19 17:18 ` [Buildroot] [PATCH v2 3/3] package/mesa3d: enable llvm support Valentin Korenblit
2018-02-21 20:55 ` [Buildroot] [PATCH v2 0/3] llvm for mesa3d Andre Renaud
2018-02-22 9:04 ` Valentin Korenblit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219212213.33f289c4@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox