From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] check-bin-arch: skip /lib/modules to allow 32-bit userland on 64-bit arch
Date: Sun, 25 Feb 2018 22:41:57 +0100 [thread overview]
Message-ID: <20180225214157.GH2276@scaer> (raw)
In-Reply-To: <20180220111156.31881-1-thomas.de_schampheleire@nokia.com>
Thomas, All,
On 2018-02-20 12:11 +0100, Thomas De Schampheleire spake thusly:
> The script check-bin-arch fails as follows on a config for PowerPC e6500
> (64-bit CPU) with BR2_ARCH="powerpc" (32-bit userland desired):
>
> ERROR: architecture for "/lib/modules/..../lib/libcrc32c.ko"
> is "PowerPC64", should be "PowerPC"
>
> This situation is perfectly acceptable: the kernel is 64-bit and so are its
> modules, even though userland is 32-bit.
>
> To keep check-bin-arch and its caller simple, just skip /lib/modules/
> entirely, like is done for /lib/firmware and some others.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> support/scripts/check-bin-arch | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/support/scripts/check-bin-arch b/support/scripts/check-bin-arch
> index 887b6613cd..f6a4569c62 100755
> --- a/support/scripts/check-bin-arch
> +++ b/support/scripts/check-bin-arch
> @@ -29,6 +29,14 @@ while read f; do
> continue
> fi
>
> + # Skip kernel modules
> + # When building a 32-bit userland on 64-bit architectures, the kernel
> + # and its modules may still be 64-bit. To keep the basic
> + # check-bin-arch logic simple, just skip this directory.
> + if [[ "${f}" =~ ^/lib/modules/.* ]]; then
> + continue
> + fi
> +
> # Skip files in /usr/share, several packages (qemu,
> # pru-software-support) legitimately install ELF binaries that
> # are not for the target architecture
> --
> 2.13.6
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-02-25 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 11:11 [Buildroot] [PATCH 1/1] check-bin-arch: skip /lib/modules to allow 32-bit userland on 64-bit arch Thomas De Schampheleire
2018-02-25 21:41 ` Yann E. MORIN [this message]
2018-02-25 22:16 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180225214157.GH2276@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox