From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] dependencies.mk: check for valid host-tar before other host dependencies
Date: Tue, 27 Feb 2018 09:55:40 +0100 [thread overview]
Message-ID: <20180227085541.11318-1-peter@korsgaard.com> (raw)
host-{cmake,lzip,xz} needs host-tar to extract their source code tarball, so
we need to ensure that host-tar gets added to DEPENDENCIES_HOST_PREREQ
before these in case they are both needed, otherwise the tools will fail to
extract.
With the upcoming change to blacklist modern tar versions this situation is
likely to trigger more often.
The real solution to this issue is the <foo>_EXTRACT_DEPENDENCIES rework,
but that series is a bit too intrusive to add this close to 2018.02, so
therefore this hack.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
Changes since v1:
- Issue not specific to lzip, so put tar in front of everything else
support/dependencies/dependencies.mk | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/support/dependencies/dependencies.mk b/support/dependencies/dependencies.mk
index 4f606f849d..3fc235863c 100644
--- a/support/dependencies/dependencies.mk
+++ b/support/dependencies/dependencies.mk
@@ -12,7 +12,10 @@
define suitable-host-package
$(shell support/dependencies/check-host-$(1).sh $(2))
endef
--include $(sort $(wildcard support/dependencies/check-host-*.mk))
+# host utilities needs host-tar to extract the source code tarballs, so
+# ensure check-host-tar.mk is included before the rest
+include support/dependencies/check-host-tar.mk
+-include $(sort $(filter-out %-tar.mk,$(wildcard support/dependencies/check-host-*.mk)))
ifeq ($(BR2_CCACHE),y)
DEPENDENCIES_HOST_PREREQ += host-ccache
--
2.11.0
next reply other threads:[~2018-02-27 8:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 8:55 Peter Korsgaard [this message]
2018-02-27 8:55 ` [Buildroot] [PATCH v2 2/2] check-host-tar.sh: blacklist tar 1.30+ Peter Korsgaard
2018-02-27 16:03 ` Peter Korsgaard
2018-04-10 20:50 ` Peter Korsgaard
2018-02-27 14:36 ` [Buildroot] [PATCH v2 1/2] dependencies.mk: check for valid host-tar before other host dependencies Matthew Weber
2018-02-27 16:03 ` Peter Korsgaard
2018-04-10 20:49 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227085541.11318-1-peter@korsgaard.com \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox