Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] systemd: switch to en_US.UTF-8 locale when building
Date: Wed, 28 Feb 2018 23:13:47 +0100	[thread overview]
Message-ID: <20180228231347.1e2896a2@windsurf.lan> (raw)
In-Reply-To: <20180228213104.GA16465@scaer>

Hello,

On Wed, 28 Feb 2018 22:31:04 +0100, Yann E. MORIN wrote:

> OK, so I do not have en_USUTF-8 on my machine. I have en_GB.UTF-8 (which
> I am using). So I'm left out in the cold with this patch.
> 
> However, C.UTF-8 is virtually available everywhere. And I was able to
> build systemd with C.UTF-8 without any problem.
> 
> So, I would  prefer, if we have to force anything, that we force the
> use of C.UTF-8.
> 
> But then that also means that we override the users' environments, users
> that may prefer to see localised messages.
> 
> So, as a stop-gap measure, I'm OK with this patch as long as it is
> switched to using C.UTF-8. Also, rename the variable, something like:
> 
>     BR2_NEEDS_HOST_UTF8_LOCALE_CURRENT
> 
> Note: this is different from the existing BR2_NEEDS_HOST_UTF8_LOCALE: it
> onlhy requires that a UTF-8 locale be present on the system, while we
> now require that it be the current locale.

Now, we don't require it to be the current locale:


> > +SYSTEMD_ENV = $(TARGET_MAKE_ENV) LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8

The systemd package ensures to pass LANG/LC_ALL pointing to an UTF-8
locale.

So even if your current locale is something else, as long as
en_US.UTF-8 is *available*, things are going to work.

That being said, I also dislike this solution, and think the sytemd
build system should be fixed instead.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

  reply	other threads:[~2018-02-28 22:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-28 11:22 [Buildroot] [PATCH 1/1] Change host locale from C to en_US.UTF-8 for reproducable builds Julius Kriukas
2018-01-30 22:38 ` Thomas Petazzoni
2018-01-31 21:34   ` Julius Kriukas
2018-01-31 21:36 ` [Buildroot] [PATCH v2] " Julius Kriukas
2018-02-04 15:19   ` Yann E. MORIN
2018-02-06 16:32   ` Thomas Petazzoni
2018-02-12 21:34   ` [Buildroot] [PATCH v3] systemd: switch to en_US.UTF-8 locale when building Julius Kriukas
2018-02-17 18:06     ` John Keeping
2018-02-22 23:02       ` Julius Kriukas
2018-02-22 23:00     ` [Buildroot] [PATCH v4] " Julius Kriukas
2018-02-28 21:31       ` Yann E. MORIN
2018-02-28 22:13         ` Thomas Petazzoni [this message]
2018-03-01 18:06           ` Yann E. MORIN
2018-03-01 18:50             ` Peter Korsgaard
2018-03-01 19:12               ` Yann E. MORIN
2018-03-01 20:04                 ` Peter Korsgaard
2018-03-02 21:45       ` Thomas Petazzoni
     [not found]         ` <87vaecbsf2.fsf@paral.in>
2018-03-04  9:01           ` Yann E. MORIN
2018-02-23  9:06     ` [Buildroot] [PATCH v3] " Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180228231347.1e2896a2@windsurf.lan \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox