Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [next, v2 4/8] cpe-info: infra defines CPE_ID_* defaults
Date: Thu, 1 Mar 2018 10:17:09 +0100	[thread overview]
Message-ID: <20180301101709.409c59eb@windsurf.lan> (raw)
In-Reply-To: <1519881819-51445-5-git-send-email-matthew.weber@rockwellcollins.com>

Hello,

On Wed, 28 Feb 2018 23:23:35 -0600, Matt Weber wrote:
> Default to using the package name for the vendor
> and name as most CPE IDs seem to align with that
> assumption. Also use the pkg version as the CPE IDs
> initial version field.

Nits:

 - You're wrapping the lines too short. Funnily, the common mistake is
   to not wrap, or wrap too long. But here, you wrap too short. 72
   characters is the good length :)

 - Missing SoB.

> v2
> [Thomas P
>  - Created patch per suggestion to use infra
>    to cleanup common case in individual pkg
>    CPE_ID definition.

I'm surprised, because I thought the conclusion of our discussion was
that it was not desirable to have such default, because then we
couldn't make the difference between packages that have had their CPE
ID explicitly added/verified by someone, and packages that have their
CPE ID defined by default, and which may be incorrect.

Have you changed your mind about this ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

  reply	other threads:[~2018-03-01  9:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01  5:23 [Buildroot] [next,v2 0/8] Package CPE Reporting Matt Weber
2018-03-01  5:23 ` [Buildroot] [next,v2 1/8] cpe-info: new make target Matt Weber
2018-03-01  5:23 ` [Buildroot] [next,v2 2/8] cpe-info: id prefix/suffix Matt Weber
2018-03-01  5:23 ` [Buildroot] [next,v2 3/8] cpe-info: only report target pkgs Matt Weber
2018-03-01  5:23 ` [Buildroot] [next, v2 4/8] cpe-info: infra defines CPE_ID_* defaults Matt Weber
2018-03-01  9:17   ` Thomas Petazzoni [this message]
2018-03-01 12:30     ` Matthew Weber
2018-03-01  5:23 ` [Buildroot] [next, v2 5/8] cpe-info: update manual for new pkg vars Matt Weber
2018-03-01  5:23 ` [Buildroot] [next,v2 6/8] bash: add CPE id Matt Weber
2018-03-01  5:23 ` [Buildroot] [next,v2 7/8] e2fsprogs: " Matt Weber
2018-03-01  5:23 ` [Buildroot] [next,v2 8/8] boa: " Matt Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180301101709.409c59eb@windsurf.lan \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox